Closed
Bug 387276
Opened 18 years ago
Closed 18 years ago
don't build xpfe components from build.mk
Categories
(SeaMonkey :: UI Design, defect)
SeaMonkey
UI Design
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: kairo, Assigned: kairo)
Details
Attachments
(1 file)
|
1.95 KB,
patch
|
benjamin
:
review-
|
Details | Diff | Splinter Review |
For making the build system easier to understand, it would be better to build all stuff in xpfe/components from the makefile there instead of doing some parts in build.mk of browser and suite.
This affects the search and bookmarks components
|
Assignee | |
Comment 1•18 years ago
|
||
This patch moves the inclusions of search and bookmarks from the two build.mk files to the xpfe/components Makefile.in
Due to this, it will be clearer visible what is built where.
Attachment #271390 -
Flags: review?(benjamin)
|
||
Comment 2•18 years ago
|
||
Comment on attachment 271390 [details] [diff] [review]
move makefile inclusion of search and bookmarks to xpfe/components
These are in tier 99 for good reasons, and shouldn't be moved back. See bug 288640
Attachment #271390 -
Flags: review?(benjamin) → review-
|
|
Assignee | |
Comment 3•18 years ago
|
||
OK, WONTFOX then for comment #2 - I guess we should move those to suite/ some time anyways (esp. once non-places-bookmarks Firefox builds get killed completely).
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•