387380 - No visible caret when caret browsing

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Simon Montagu :smontagu]

In caret browsing mode, there is no visible caret on the page. Apart from that, caret browsing still works: when pressing the arrow keys with shift or control, text is selected.

Regression range: 2007-06-27-05 works; 2007-06-28-04 has the bug. Regression from bug 237964?

Comment 4

[Peter Van der Beken [:peterv]]

Attachment: v1

Comment 5

[Peter Van der Beken [:peterv]]

I'm going to be away for two weeks, so I'd appreciate it if someone could check this in when it's reviewed.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Could you upload a -u8p patch?
The comments in nsICaret.h don't quite make sense.

(I can check this in)

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 272992 [details] [diff] [review]
v1


>+  /**
>+   * Sets whether the caret should only be visible in nodes that do are not
>+   * user-modify: read-only, or whether it should be visible in all nodes.
>+   *
>+   * @param aIgnoreReadWrite PR_TRUE to have the cursor visible in all nodes,
>+   *                         PR_FALSE to have it visible in all nodes except
>+   *                         those with user-modify: read-only
>+   */
>+  virtual void SetIgnoreUserModify(PRBool aIgnoreUserModify) = 0;


The comment should be probably:
"   * Sets whether the caret should only be visible in nodes that are not
    * user-modify: read-only, or whether it should be visible in all nodes.
    *
    * @param aIgnoreUserModify PR_TRUE to have the cursor visible in all nodes,
    *                          PR_FALSE to have it visible in all nodes except
    *                          those with user-modify: read-only
"

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Could you comment about the risk of this patch?

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Peterv should be back soon, hopefully he can comment on that.

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 272992 [details] [diff] [review]
v1

Actually, this is blocking+, so no need for approval.

Comment 11

[Georg Maaß]

Does this fix cause this trouble?

https://bugzilla.mozilla.org/show_bug.cgi?id=391819