Closed Bug 387392 Opened 19 years ago Closed 19 years ago

Remove overrides from extensions.xml

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9alpha8

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

Details

Attachments

(1 file, 2 obsolete files)

Now that bug 298371 the existing overrides in extensions.xml are no longer needed and should be removed.
Attached patch first pass (obsolete) — — Splinter Review
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Attached patch second pass (obsolete) — — Splinter Review
note: need to figure out the behavior when navigating the view panes, etc.
Attachment #271502 - Attachment is obsolete: true
Simon, what is the logic behind richlistbox:focus? Specifically, why does the richlistbox have focus when an immediate richlistitem child is focused but not when elements within the richlistiem is focused?
(In reply to comment #3) > what is the logic behind richlistbox:focus? I'm not sure - guess the focus stays with the next focusable element, moving from child to parent. Neil should be able to clarify this much better than me, though.
Attached patch patch — — Splinter Review
Dave, I'd like to get this in for M8. It does the cleanup of the code that is not used and fixes focus. Fixing functionality can be done in a followup bug.
Attachment #271503 - Attachment is obsolete: true
Attachment #279532 - Flags: review?(dtownsend)
Comment on attachment 279532 [details] [diff] [review] patch r=me, let's get this in.
Attachment #279532 - Flags: review?(dtownsend) → review+
Checked in to trunk Checking in mozilla/toolkit/themes/pinstripe/mozapps/extensions/extensions.css; /cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/extensions/extensions.css,v <-- extensions.css new revision: 1.29; previous revision: 1.28 done Checking in mozilla/toolkit/themes/winstripe/mozapps/extensions/extensions.css; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/extensions.css,v <-- extensions.css new revision: 1.33; previous revision: 1.32 done Checking in mozilla/toolkit/mozapps/extensions/content/extensions.xml; /cvsroot/mozilla/toolkit/mozapps/extensions/content/extensions.xml,v <-- extensions.xml new revision: 1.47; previous revision: 1.46 done Checking in mozilla/toolkit/mozapps/extensions/content/extensions.js; /cvsroot/mozilla/toolkit/mozapps/extensions/content/extensions.js,v <-- extensions.js new revision: 1.145; previous revision: 1.144 done Checking in mozilla/toolkit/mozapps/extensions/content/extensions.xul; /cvsroot/mozilla/toolkit/mozapps/extensions/content/extensions.xul,v <-- extensions.xul new revision: 1.63; previous revision: 1.62 done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M8
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: