Closed
Bug 387395
Opened 18 years ago
Closed 18 years ago
talos computes Median value incorrectly
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)
Details
Attachments
(1 file)
|
2.40 KB,
patch
|
anodelman
:
review+
|
Details | Diff | Splinter Review |
In framecycler.html, Median value is computed incorrectly.
It has 2 problems.
1) sorted_ary.sort is not sorted without compare function, so it's sorted lexicographically.
2) sorted_ary is zero based. so we should use (a[n-1] + a[n]) /2 for median value, if length is even. (n = length / 2.)
Also Median is not in tables heads of report.html
I pressed submit too fast.
I mean table headers in report.html.
Attachment #271504 -
Flags: review?(rhelmer)
|
||
Comment 3•18 years ago
|
||
Comment on attachment 271504 [details] [diff] [review]
patch
Sorry for the delay; alice would be a better reviewer than me for this.
Attachment #271504 -
Flags: review?(rhelmer) → review?(anodelman)
|
|
||
Comment 4•18 years ago
|
||
Comment on attachment 271504 [details] [diff] [review]
patch
The math in this patch looks good to me.
Attachment #271504 -
Flags: review?(anodelman) → review+
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Comment 5•18 years ago
|
||
Ginn checked this in on 2007-07-18 23:33, FWIW.
|
||
Updated•17 years ago
|
Component: Testing → Release Engineering: Talos
Product: Core → mozilla.org
QA Contact: testing → release
Version: Trunk → other
|
||
Updated•12 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•