Closed Bug 387549 Opened 18 years ago Closed 18 years ago

bad lineends in source files

Categories

(Calendar :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: michael.buettner, Assigned: michael.buettner)

Details

Attachments

(1 file, 1 obsolete file)

I just discovered that two files in /m/c/lightning/content contain DOS line-ends, namely messenger-overlay-sidebar.js and messenger-overlay-toolbar.js. This should be corrected since otherwise patch/diff will erroneously report changes on those affected lines.
Attached patch patch v1 (obsolete) — Splinter Review
Obviously the patch doesn't contain any real changes, but it indicates the offending lines.
Attachment #271678 - Flags: review?(philipp)
Attachment #271678 - Flags: review?(philipp) → review+
Attached patch patch v2Splinter Review
Looks good. While we are at it, I fixed some style nits in the lines that are being changed, feel free to use this version.
Attachment #271678 - Attachment is obsolete: true
patch checked in on trunk and MOZILLA_1_8_BRANCH -> FIXED
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.7
verified
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: