387607 - When going back in a browser or looking at a restored browser session, "edit attachment as comment" is hidden even though is content in the comment

Status: NEW

(Bugzilla :: Attachments & Requests, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

Firefox's Session Restore feature restores the content of the "editFrame" textarea on Bugzilla's Attachment Details page when the "Edit Attachment as Comment" button has been pressed, but because it doesn't restore the DOM or JS state of the page (bug 387598), the restored page isn't in "edit attachment as comment" mode, and pressing the button wipes out the value in the editFrame textarea, replacing it with a fresh version of the attachment.

To work around this problem until Session Restore becomes capable of restoring the entire state of the page, Bugzilla should check for the presence of content in the textarea after session restore restores the content of that field, and if there's content in it, Bugzilla shouldn't overwrite it when the user clicks "Edit Attachment as Comment" and should switch into "edit attachment as comment" mode.

Comment 1

[timeless]

Attachment: only replace whitetext

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 275383 [details] [diff] [review]
only replace whitetext

Looks good, r=myk

Comment 3

[Max Kanat-Alexander]

Oh, this should be helpful for people hitting the back button, too, yes? Lord knows how many reviews I've lost that way...

Comment 4

[timeless]

Comment on attachment 275383 [details] [diff] [review]
only replace whitetext

mozilla/webtools/bugzilla/template/en/default/attachment/edit.html.tmpl 	1.46

BUGZILLA-3_0-BRANCH:
mozilla/webtools/bugzilla/template/en/default/attachment/edit.html.tmpl 	1.41.2.2

Comment 5

[Frédéric Buclin]

Comment on attachment 275383 [details] [diff] [review]
only replace whitetext

)I(*"/ç(/Z*"Qç)(Z()Q*Zç)N(Q/*ç!!!!!!!

Error : editFrame.value.test is not a function
Source file: https://localhost/bugzilla/attachment.cgi?id=45&action=edit
Line : 226

Comment 6

[Frédéric Buclin]

The patch has been backed out from both trunk and the 3.0 branch. Thanks again timeless for not testing your patches and breaking attachments. You cannot edit any attachment anymore with your patch applied!

tip:

Checking in template/en/default/attachment/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.47; previous revision: 1.46
done

3.0.1:

Checking in template/en/default/attachment/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.41.2.3; previous revision: 1.41.2.2
done

Comment 7

[timeless]

Attachment: regexp in the right position (hopefully)

Comment 8

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 288980 [details] [diff] [review]
regexp in the right position (hopefully)

Canceling this review request, as I'm no longer able to do Bugzilla reviews.

Comment 9

[Max Kanat-Alexander]

LpSolit: Now that we've changed how this works, is this necessary anymore?

Comment 10

[Frédéric Buclin]

(In reply to comment #9)
> LpSolit: Now that we've changed how this works, is this necessary anymore?

The patch no longer applies, but the problem still exists yes (tested right now with Firefox 3.5.2).