Closed
Bug 387615
Opened 18 years ago
Closed 18 years ago
case sensitivity attribute value checks shouldn't apply to namespaced attributes
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
People
(Reporter: dbaron, Assigned: dbaron)
Details
Attachments
(1 file)
|
864 bytes,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
Currently we apply the tests for case-sensitivity of attribute values to both un-namespaced attributes and HTML-namespaced attributes. They should only apply to the former. See bug 357614.
|
Assignee | |
Comment 1•18 years ago
|
||
When reviewing this, you might also want to review what I landed for bug 357614, i.e., http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/layout/style&command=DIFF_FRAMESET&file=nsCSSParser.cpp&rev1=3.363&rev2=3.364&root=/cvsroot
Attachment #271762 -
Flags: superreview?(bzbarsky)
Attachment #271762 -
Flags: review?(bzbarsky)
|
||
Comment 2•18 years ago
|
||
Comment on attachment 271762 [details] [diff] [review]
patch
Looks good. Check in some tests too?
Attachment #271762 -
Flags: superreview?(bzbarsky)
Attachment #271762 -
Flags: superreview+
Attachment #271762 -
Flags: review?(bzbarsky)
Attachment #271762 -
Flags: review+
|
|
Assignee | |
Comment 3•18 years ago
|
||
Fix checked in to trunk, with test in mozilla/layout/style/test/test_bug387615.html .
Status: NEW → RESOLVED
Closed: 18 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•