Closed Bug 387725 Opened 17 years ago Closed 17 years ago

"Assertion failure: !fp->dormantNext"

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
critical

Tracking

()

RESOLVED FIXED

People

(Reporter: jruderman, Assigned: mrbkap)

References

Details

(Keywords: assertion)

Attachments

(1 file)

Assertion failure: !fp->dormantNext, at /Users/jruderman/trunk/mozilla/js/src/jsapi.c:4921 or Assertion failure: !chain->dormantNext, at /Users/jruderman/trunk/mozilla/js/src/jsgc.c:2432 I wasn't able to make a nice testcase because the bug depends on cycle collection timing, but mrbkap figured out the bug after I trapped it in the debugger, and I think he has a patch.
Attached patch Proposed fixSplinter Review
I think that this is just at simple oversight on Igor's part: he always sets acx->fp->dormantNext, but only unsets it if we're a marking tracer, which isn't always the case.
Assignee: general → mrbkap
Status: NEW → ASSIGNED
Attachment #271904 - Flags: review?(igor)
Comment on attachment 271904 [details] [diff] [review] Proposed fix Yep, the code must always undo dormantNext.
Attachment #271904 - Flags: review?(igor) → review+
Fix checked into trunk.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
Flags: wanted1.8.1.x+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: