Last Comment Bug 387738 - Using repeat index for 1.1 delete does not work
: Using repeat index for 1.1 delete does not work
: fixed1.8.1.5
Product: Core Graveyard
Classification: Graveyard
Component: XForms (show other bugs)
: Trunk
: x86 Windows XP
-- normal (vote)
: ---
Assigned To: Merle Sterling
Depends on:
  Show dependency treegraph
Reported: 2007-07-11 15:15 PDT by Merle Sterling
Modified: 2016-07-15 14:46 PDT (History)
3 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---

testcase (1.78 KB, application/xhtml+xml)
2007-07-11 15:20 PDT, Merle Sterling
no flags Details
patch (1.11 KB, patch)
2007-07-11 15:30 PDT, Merle Sterling
aaronr: review-
Details | Diff | Splinter Review
patch2 (3.36 KB, patch)
2007-07-12 10:04 PDT, Merle Sterling
aaronr: review+
doronr: review+
Details | Diff | Splinter Review

Description User image Merle Sterling 2007-07-11 15:15:59 PDT
User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; .NET CLR 1.1.4322; .NET CLR 2.0.50727)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a5pre) Gecko/20070507 Minefield/3.0a5pre

Repeat indexes are not updated and no node is deleted when the delete location is specified by an xpath expression like index('lineset') [where 'lineset' is the id of the repeat.

Reproducible: Always

Steps to Reproduce:
Run the attached testcase and add a line or two and then select a row and delete it.

Actual Results:  
Current index does not change and no node is deleted.

Expected Results:  
Selected line should be deleted and current index updated to reflect the current number of rows.
Comment 1 User image Merle Sterling 2007-07-11 15:20:42 PDT
Created attachment 271913 [details]
Comment 2 User image Merle Sterling 2007-07-11 15:30:17 PDT
Created attachment 271915 [details] [diff] [review]

We were using the 'locationNode' to determine the instance data node for sending the insert/delete event. Because delete can now delete multiple nodes, the locationNode will get set to null when we reach the end of the set of nodes to delete and GetInstanceNodeForData will fail - we then exit without rebuild/recalculate/refresh and the display does not get updated.
Comment 3 User image aaronr 2007-07-11 17:17:10 PDT
Comment on attachment 271915 [details] [diff] [review]

Actually, I think it'd be safer to perhaps get this earlier in the process since resNode has already been removed from the DOM in the case of 'delete'.
Comment 4 User image Merle Sterling 2007-07-12 10:04:20 PDT
Created attachment 272034 [details] [diff] [review]

Getting the instance data node before performing the delete.
Comment 5 User image aaronr 2007-07-12 14:02:00 PDT
checked into trunk and 1.8 branch for msterlin

Note You need to log in before you can comment on or make changes to this bug.