387833 - Cannot add keyword bookmark

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Al Billings [:abillings - ex-MoCo]]

Related to 385316 (where the repro steps initially came from).

Steps to reproduce:

1. Go to http://www.howstuffworks.com/
2. In the web site's search field right click and choose: "Add a Keyword for
this Search"
3. Enter anything for the name and anything for a keyword.
4. Click on "Add"

Expected Result: Keyboard bookmark is added.
Actual Result: No bookmark added. Add bookmark dialog does not receive the click on the "add" button and does not dismiss.

Found on: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a7pre) Gecko/200707110404 Minefield/3.0a7pre

Comment 1

[Carsten Book [:Tomcat]]

- Error: uncaught exception: [Exception... "'[JavaScript Error: "annos.setPageAnnotationString is not a function" {file: "chrome://browser/content/places/utils.js" line: 1307}]' when calling method: [nsITransaction::doTransaction]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: chrome://browser/content/places/bookmarkProperties.js :: BPP__getCreateItemTransaction :: line 1003"  data: yes]

from Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9a7pre) Gecko/200707110505 Minefield/3.0a7pre with the steps to reproduce from Al.

Comment 2

[Phil Ringnalda (:philor)]

Attachment: Fix

Mano should check whether Mano is using something before Mano makes it impossible for Mano to use it :)

Comment 3

[Asaf Romano (gone)]

Comment on attachment 271966 [details] [diff] [review]
Fix

r++

Comment 4

[Phil Ringnalda (:philor)]

browser/components/places/content/utils.js 1.49

Comment 5

[Al Billings [:abillings - ex-MoCo]]

Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a7pre) Gecko/200707120404 Minefield/3.0a7pre.

Comment 6

[Tracy Walker [:tracy]]

in litmus http://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=4136

Comment 7

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv