Closed
Bug 387910
Opened 17 years ago
Closed 17 years ago
mozilla-central .hgignore file is incomplete
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jorendorff, Assigned: jorendorff)
Details
Attachments
(2 files)
247 bytes,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
247 bytes,
patch
|
jorendorff
:
review-
|
Details | Diff | Splinter Review |
"hg status" should skip over: * Emacs ~ files * directories pulled from CVS The way to do this is to add the right regexps to .hgignore.
Attachment #272044 -
Flags: review?(ted.mielczarek)
Assignee | ||
Comment 1•17 years ago
|
||
(The previous patch deleted regexps for CVS directories. Mistake.)
Attachment #272044 -
Attachment is obsolete: true
Attachment #272044 -
Flags: review?(ted.mielczarek)
Assignee | ||
Updated•17 years ago
|
Attachment #272046 -
Flags: review?(ted.mielczarek)
Updated•17 years ago
|
Attachment #272044 -
Flags: review+
Assignee | ||
Comment 2•17 years ago
|
||
Comment on attachment 272044 [details] [diff] [review] .hgignore patch OK, after a cup of coffee I think the first patch is the correct one. CVS directories shouldn't show up in your Mercurial repository, with the exception of the cvs-trunk-mirror repository. So I'll check the first patch into mozilla-central (and not cvs-trunk-mirror).
Attachment #272044 -
Attachment is obsolete: false
Assignee | ||
Updated•17 years ago
|
Attachment #272046 -
Flags: review?(ted.mielczarek) → review-
Comment 3•17 years ago
|
||
CVS directories *do* show up when we're doing import from CVS, and so .hgignore must continue to ignore them. Please don't change this, as it's important ;-)
Assignee | ||
Comment 4•17 years ago
|
||
Pushed changeset 899ca1f39f07 to hg.mozilla.org/mozilla-central .
Status: NEW → RESOLVED
Closed: 17 years ago
OS: Mac OS X → All
Hardware: PC → All
Resolution: --- → FIXED
Assignee | ||
Comment 5•17 years ago
|
||
bs: Just talked with luser about this on IRC... I think we should only be doing import from CVS in cvs-trunk-mirror. If a CVS directory showed up in your mozilla-central or actionmonkey repository, it would mean something weird has happened somewhere, and you might as well know about it. So this change would be bad in cvs-trunk-mirror, but it makes sense in mozilla-central (where it's committed right now). Or so the theory goes. Let me know.
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•