Closed Bug 388036 Opened 17 years ago Closed 17 years ago

Make Bugzilla::Bug do updating for alias in process_bug.

Categories

(Bugzilla :: Creating/Changing Bugs, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 3.2

People

(Reporter: mkanat, Assigned: mkanat)

References

Details

Attachments

(1 file, 1 obsolete file)

The "alias" field should also be very easy to handle, using update().
Attached patch v1 (obsolete) — Splinter Review
Very simple, as I thought.
Attachment #272180 - Flags: review?(LpSolit)
Blocks: 388045
Attached patch v2Splinter Review
Okay, this eliminates ValidateBugAlias and fixes the error that happened when setting a bug's alias to itself.
Attachment #272180 - Attachment is obsolete: true
Attachment #272187 - Flags: review?(LpSolit)
Attachment #272180 - Flags: review?(LpSolit)
Attachment #272187 - Attachment is patch: true
Attachment #272187 - Attachment mime type: text/x-patch → text/plain
Comment on attachment 272187 [details] [diff] [review]
v2

>Index: Bugzilla/Bug.pm

> #   Check that the bug alias is valid and not used by another bug.  If 
> #   curr_id is specified, verify the alias is not used for any other
> #   bug id.  
>-sub ValidateBugAlias {

Two things:
1) Remove this comment which is no longer needed as the routine has gone.
2) Remove ValidateBugAlias from @Bugzilla::Bug::EXPORT as well.

Else your patch works fine. r=LpSolit
Attachment #272187 - Flags: review?(LpSolit) → review+
Flags: approval+
Okay, I fixed both those things.

Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.377; previous revision: 1.376
done
Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.191; previous revision: 1.190
done
Checking in Bugzilla/WebService/Constants.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/WebService/Constants.pm,v  <--  Constants.pm
new revision: 1.7; previous revision: 1.6
done
Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v  <--  user-error.html.tmpl
new revision: 1.216; previous revision: 1.215
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: