Last Comment Bug 388048 - mozIStorageStatement::getParameterIndexes is useless
: mozIStorageStatement::getParameterIndexes is useless
Product: Toolkit
Classification: Components
Component: Storage (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla1.9alpha8
Assigned To: Shawn Wilsher :sdwilsh
: Marco Bonardo [::mak]
Depends on:
Blocks: 387945
  Show dependency treegraph
Reported: 2007-07-13 09:39 PDT by Shawn Wilsher :sdwilsh
Modified: 2007-07-15 11:06 PDT (History)
0 users
sdwilsh: in‑testsuite+
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

proof (847 bytes, text/plain)
2007-07-13 09:39 PDT, Shawn Wilsher :sdwilsh
no flags Details
v1.0 (6.99 KB, patch)
2007-07-13 21:53 PDT, Shawn Wilsher :sdwilsh
moco: review+
Details | Diff | Splinter Review

Description User image Shawn Wilsher :sdwilsh 2007-07-13 09:39:22 PDT
Created attachment 272192 [details]

It returns an array in case it was used more than once, but sqlite magically takes care of that for us.  It should be renamed to getParameterIndex and return an int.

Attached is a testcase demonstrating that sqlite does in fact handle this gracefully.
Comment 1 User image Shawn Wilsher :sdwilsh 2007-07-13 21:53:34 PDT
Created attachment 272284 [details] [diff] [review]

On the right bug too :)
Comment 2 User image (not reading, please use instead) 2007-07-14 22:51:31 PDT
Comment on attachment 272284 [details] [diff] [review]

Comment 3 User image Shawn Wilsher :sdwilsh 2007-07-15 11:06:17 PDT
Checking in storage/public/mozIStorageStatement.idl;
new revision: 1.7; previous revision: 1.6
Checking in storage/src/mozStorageStatement.cpp;
new revision: 1.23; previous revision: 1.22
Checking in storage/test/unit/test_storage_statement.js;
new revision: 1.3; previous revision: 1.2

Note You need to log in before you can comment on or make changes to this bug.