The default bug view has changed. See this FAQ.

mozIStorageStatement::getParameterIndexes is useless

RESOLVED FIXED in mozilla1.9alpha8

Status

()

Toolkit
Storage
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: sdwilsh, Assigned: sdwilsh)

Tracking

Trunk
mozilla1.9alpha8
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

847 bytes, text/plain
Details
6.99 KB, patch
(not reading, please use seth@sspitzer.org instead)
: review+
Details | Diff | Splinter Review
(Assignee)

Description

10 years ago
Created attachment 272192 [details]
proof

It returns an array in case it was used more than once, but sqlite magically takes care of that for us.  It should be renamed to getParameterIndex and return an int.

Attached is a testcase demonstrating that sqlite does in fact handle this gracefully.
(Assignee)

Updated

10 years ago
Blocks: 387945
(Assignee)

Comment 1

10 years ago
Created attachment 272284 [details] [diff] [review]
v1.0

On the right bug too :)
Attachment #272284 - Flags: review?(sspitzer)
Comment on attachment 272284 [details] [diff] [review]
v1.0

r=sspitzer
Attachment #272284 - Flags: review?(sspitzer) → review+
(Assignee)

Comment 3

10 years ago
Checking in storage/public/mozIStorageStatement.idl;
new revision: 1.7; previous revision: 1.6
Checking in storage/src/mozStorageStatement.cpp;
new revision: 1.23; previous revision: 1.22
Checking in storage/test/unit/test_storage_statement.js;
new revision: 1.3; previous revision: 1.2
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9beta1
You need to log in before you can comment on or make changes to this bug.