Last Comment Bug 388120 - build error due to SEC_BEGIN_PROTOS / SEC_END_PROTOS are undefined
: build error due to SEC_BEGIN_PROTOS / SEC_END_PROTOS are undefined
Status: RESOLVED FIXED
:
Product: NSS
Classification: Components
Component: Libraries (show other bugs)
: trunk
: x86 Windows XP
: -- normal (vote)
: 3.12
Assigned To: alexander :surkov
:
Mentors:
Depends on:
Blocks: 118830
  Show dependency treegraph
 
Reported: 2007-07-13 21:31 PDT by alexander :surkov
Modified: 2007-07-16 23:30 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (1.01 KB, patch)
2007-07-13 21:31 PDT, alexander :surkov
nelson: review+
Details | Diff | Splinter Review

Description alexander :surkov 2007-07-13 21:31:59 PDT
Created attachment 272282 [details] [diff] [review]
patch

It looks "seccomon.h" should be included to avoid the build error (see a bug 118830)
Comment 1 Nelson Bolyard (seldom reads bugmail) 2007-07-13 21:50:40 PDT
what software fails to build due to this issue?
Is this fix needed on any NSS branches? or only the trunk?
Comment 2 Nelson Bolyard (seldom reads bugmail) 2007-07-13 21:52:11 PDT
Comment on attachment 272282 [details] [diff] [review]
patch

r=nelson for trunk.
I think this is only needed on the trunk.
Comment 3 alexander :surkov 2007-07-13 22:05:31 PDT
(In reply to comment #1)
> what software fails to build due to this issue?
> Is this fix needed on any NSS branches? or only the trunk?
> 

Yes, it's on trunk only. I build firefox, the sources I get by cvs update (not by make checkout).
Comment 4 Nelson Bolyard (seldom reads bugmail) 2007-07-13 22:25:43 PDT
Alexander, Browser builds are NEVER supposed to use the tip of the NSS trunk.
NSS supplies stable static tags for use by the browser.  
The browser's makefile  knows these tags and pulls the NSS sources using them.
If you pull NSS sources from the trunk, you will run into a lot of problems
that no other browser builders see, because they are all pulling from the 
approved tag.  The NSS team does not promise at any time that the tip of 
the trunk will build and work in the browser.  That promise is only made for
the tags that the NSS team has approved for use by the browser.  

I'm not trying to rebuke you for using NSS trunk.  I just want you to know
that there is a way to build the browser that is much less painful than the
method of pulling NSS from the tip of the trunk.  

OTOH, sometimes reports like yours help us to notice and fix problems sooner
than we otherwise would.  So, if you don't mind enduring the pain and the 
risk of using the NSS trunk, please feel free to continue.  :)

I think your patch will get checked in this weekend.  Thanks for that patch.
Comment 5 alexander :surkov 2007-07-13 22:33:29 PDT
(In reply to comment #4)
> 
> OTOH, sometimes reports like yours help us to notice and fix problems sooner
> than we otherwise would.  So, if you don't mind enduring the pain and the 
> risk of using the NSS trunk, please feel free to continue.  :)

I use trunk browser only as html/xul renderer to check accessibility so usually trunk sources doesn't bring me any pain :).

> I think your patch will get checked in this weekend.  Thanks for that patch.
> 

No problem. I guess I can check in it myself if it doesn't require any special CVS rights.
Comment 6 Nelson Bolyard (seldom reads bugmail) 2007-07-13 23:22:49 PDT
NSS does require special CVS rights.  Thanks again for the patch.

Checking in util/secdert.h; new revision: 1.4; previous revision: 1.3

Note You need to log in before you can comment on or make changes to this bug.