Crash closing detached JavaScript alert sheet [@ TestWindowGroupAttributes] [@ nsMacEventHandler::HandleActivateEvent]

RESOLVED FIXED

Status

Core Graveyard
Widget: Mac
--
critical
RESOLVED FIXED
10 years ago
6 years ago

People

(Reporter: David D. Kilzer (ddk), Assigned: mats)

Tracking

({crash, testcase, verified1.8.1.8})

1.8 Branch
PowerPC
Mac OS X
crash, testcase, verified1.8.1.8
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(crash signature, URL)

Attachments

(4 attachments)

(Reporter)

Description

10 years ago
* SUMMARY
Crash in Firefox 2.0.0.4 on Mac OS X 10.4.10 (8R218) when opening a particular URL, closing the browser window, then closing a detached JavaScript alert sheet.

* STEPS TO REPRODUCE
1. Launch Firefox 2.0.0.4.
2. Open URL:  http://bugs.webkit.org/attachment.cgi?id=15496
3. Wait until "Whatever" appears in right frame.  (NOTE: Page never stops loading.)
4. Close browser window.
5. Switch to another OS X application (Finder, whatever).
6. Switch back to Firefox.
7. Dismiss JavaScript alert sheet that has now been painted without a browser window.
8. Firefox crashes.

* REGRESSION
Only tested with Firefox 2.0.0.4 on Mac OS X 10.4.10 (8R218).

* NOTES
Talkback incident filed on the first crash (subsequent crashes did not create a Talkback incident):

http://talkback-public.mozilla.org/search/start.jsp?search=2&type=iid&id=34039143

The attachment that causes a crash is for this WebKit bug:

http://bugs.webkit.org/show_bug.cgi?id=14599
no crash for me with Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.5) Gecko/2007071317 Firefox/2.0.0.5 - 2005 RC2 
(Reporter)

Comment 2

10 years ago
Created attachment 272346 [details]
Extensions installed

Is there a better way to list extensions installed than a screenshot?
(Assignee)

Comment 3

10 years ago
I can reproduce the crash in 2.0.0.4 and 2.0.0.5-RC2 on MacOSX 10.4.10
(no add-ons except the default DOMI and Talkback).  The crash didn't
trigger Talkback for me.
Assignee: nobody → joshmoz
Severity: normal → critical
Component: General → Widget: Cocoa
Product: Firefox → Core
QA Contact: general → cocoa
Version: 2.0 Branch → 1.8 Branch
Mats, can you attach a system crash log?
(Assignee)

Comment 5

10 years ago
Created attachment 272426 [details]
Crash data
1.8-only, and thus Widget: Mac rather than Widget: Cocoa, no?
(Assignee)

Comment 7

10 years ago
True.
Component: Widget: Cocoa → Widget: Mac
QA Contact: cocoa → mac
(Assignee)

Comment 8

10 years ago
Created attachment 272494 [details] [diff] [review]
Patch rev. 1

Reset sLastActive when the window is destroyed.
Nulling out mWindowPtr isn't necessary to fix the crash here but it
makes the code more robust against similar problems in the future.
Assignee: joshmoz → mats.palmgren
Status: NEW → ASSIGNED
Attachment #272494 - Flags: review?(joshmoz)
(Assignee)

Comment 9

10 years ago
I think bug 378990 is the same thing.
Blocks: 378990

Updated

10 years ago
Attachment #272494 - Flags: review?(joshmoz) → review+
(Assignee)

Comment 10

10 years ago
Comment on attachment 272494 [details] [diff] [review]
Patch rev. 1

sr for branches please.
Attachment #272494 - Flags: superreview?(roc)
Attachment #272494 - Flags: superreview?(roc) → superreview+
(Assignee)

Updated

10 years ago
Attachment #272494 - Flags: approval1.8.1.7?
Attachment #272494 - Flags: approval1.8.1.6?
Attachment #272494 - Flags: approval1.8.1.6?

Updated

10 years ago
Keywords: talkbackid
Summary: Crash closing detached JavaScript alert sheet → Crash closing detached JavaScript alert sheet [@ TestWindowGroupAttributes] [@ nsMacEventHandler::HandleActivateEvent]

Comment 11

10 years ago
Andrew Schultz thought that my issue might be this bug. Here's my details:

Mac G4/733 1.5gb ram, OS 10.4.10.

FF v2.0.0.6
SM v1.1.4

When accessing American Airlines employee flight booking site SM crashes (unexpected quit) out each time. But FireFox works fine. Both at latest shipping versions. I have crash logs.

But I can't tell anyone how to reproduce the problem as I can't give out my wife's employee login credentials. Way too many things hide behind this login.

Want me to post a crash log?
(Reporter)

Comment 12

10 years ago
(In reply to comment #11)
> Want me to post a crash log?

Have you submitted the crashes to Talkbalk?  If so, post the Talkback IDs here.

Comment 13

10 years ago
(In reply to comment #12)
> (In reply to comment #11)
> > Want me to post a crash log?
> 
> Have you submitted the crashes to Talkbalk?  If so, post the Talkback IDs here.
> 

SeaMonkey v1.1.4 has talkback?
(Reporter)

Comment 14

10 years ago
(In reply to comment #13)
> SeaMonkey v1.1.4 has talkback?

It doesn't?  Sorry, I assumed it did.  Does this reproduce on Firefox 2.0.0.x?

(Reporter)

Comment 15

10 years ago
(In reply to comment #11)
> Want me to post a crash log?

Yes, please attach crash logs.

Comment 16

10 years ago
Created attachment 277435 [details]
Crash Log for SM when FF works ok

A crash log for the following setup:
Mac G4/733 1.5gb ram, OS 10.4.10.

FF v2.0.0.6
SM v1.1.4

No extensions installed.

When accessing American Airlines employee flight booking site SM crashes
(unexpected quit) out each time. But FireFox works fine. Both at latest
shipping versions. I have crash logs.

But I can't tell anyone how to reproduce the problem as I can't give out my
wife's employee login credentials. Way too many things hide behind this login.
Comment on attachment 272494 [details] [diff] [review]
Patch rev. 1

approved for 1.8.1.7, a=dveditz for release-drivers
Attachment #272494 - Flags: approval1.8.1.7? → approval1.8.1.7+
(Assignee)

Comment 18

10 years ago
Checked in on MOZILLA_1_8_BRANCH

mozilla/widget/src/mac/nsMacEventHandler.cpp 	1.172.4.25
mozilla/widget/src/mac/nsMacEventHandler.h 	1.41.4.14
mozilla/widget/src/mac/nsMacWindow.cpp 	1.158.2.30
mozilla/widget/src/mac/nsWindow.cpp 	1.232.2.9 

-> FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: fixed1.8.1.8
Resolution: --- → FIXED

Updated

10 years ago
Blocks: 399065
verified fixed for 1.8.1.8 using Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.8) Gecko/2007100816 Firefox/2.0.0.8 and the steps to reproduce from comment #0 

no crash -> adding verified keyword
Keywords: fixed1.8.1.8 → verified1.8.1.8

Updated

8 years ago
Component: Widget: Mac → Widget: Mac
Product: Core → Core Graveyard
Crash Signature: [@ TestWindowGroupAttributes] [@ nsMacEventHandler::HandleActivateEvent]
You need to log in before you can comment on or make changes to this bug.