388192 - Remove gopher OS integration support

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect)

Description

[Robert Strong (they/them - no direct email)]

This will remove a potential attack vector as seen with
http://larholm.com/2007/06/12/safari-for-windows-0day-exploit-in-2-hours/

This bug is not about removing the gopher protocol entirely

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: Windows patch (checked in)

I'm not going to do the Mac OS X or Linux patches at this time but I'd like to get the Windows one in.

Comment 2

[Mike Schroepfer]

Nomin for security reasons

Comment 3

[Robert Strong (they/them - no direct email)]

If someone more familiar with OS integration on Mac OS X and Linux would create patches for them I'd be a happy camper.

Windows patch checked in to trunk.

Checking in mozilla/browser/components/shell/src/nsWindowsShellService.cpp;
/cvsroot/mozilla/browser/components/shell/src/nsWindowsShellService.cpp,v  <--  nsWindowsShellService.cpp
new revision: 1.48; previous revision: 1.47
done
Checking in mozilla/browser/installer/windows/nsis/shared.nsh;
/cvsroot/mozilla/browser/installer/windows/nsis/shared.nsh,v  <--  shared.nsh
new revision: 1.11; previous revision: 1.10
done

Comment 4

[Robert Strong (they/them - no direct email)]

oops! didn't mean to resolve this yet

Comment 5

[Robert Strong (they/them - no direct email)]

Attachment: patch for Mac OS X

Not sure if additional cleanup is required.

Comment 6

[Robert Strong (they/them - no direct email)]

Attachment: patch for Linux (checked in)

Not sure if additional cleanup is required.

Comment 7

[Robert Strong (they/them - no direct email)]

Comment on attachment 272691 [details] [diff] [review]
patch for Mac OS X

I discussed this change with Josh and since we already don't register as the default gopher handler on Mac OS X there should be no additional cleanup needed.
http://lxr.mozilla.org/seamonkey/source/browser/components/shell/src/nsMacShellService.cpp#151

Comment 8

[(not reading, please use [e-mail] instead)]

Comment on attachment 272691 [details] [diff] [review]
patch for Mac OS X

sorry for the delay.

r=sspitzer, given that you discussed it with josh.

Comment 9

[Robert Strong (they/them - no direct email)]

Comment on attachment 272691 [details] [diff] [review]
patch for Mac OS X

Mac OS X patch checked in to trunk

Checking in mozilla/browser/app/macbuild/Contents/Info.plist.in;
/cvsroot/mozilla/browser/app/macbuild/Contents/Info.plist.in,v  <--  Info.plist.in
new revision: 1.16; previous revision: 1.15
done

Comment 10

[Mike Connor [:mconnor]]

Punting to M8 for the Linux piece to get finished up.

Comment 11

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 272692 [details] [diff] [review]
patch for Linux (checked in)

r=[e-mail]

Comment 12

[Robert Strong (they/them - no direct email)]

caillon, is there any additional cleanup needed if the application was set as the default gopher handler?

Comment 13

[Robert Strong (they/them - no direct email)]

Linux patch checked in on trunk

Checking in mozilla/browser/components/shell/src/nsGNOMEShellService.cpp;
/cvsroot/mozilla/browser/components/shell/src/nsGNOMEShellService.cpp,v  <--  nsGNOMEShellService.cpp
new revision: 1.21; previous revision: 1.20
done

Comment 14

[amano]

wow. this is a great idea. remove attack vectors by removing protocols. So did mozilla with thunderbird: they just "removed" smtp from mozilla. No thunderbird --> no --> smtp --> no attack vectors. I hope that the next logical step is to remove http. No http --> no people coming up with that stupid ideas. An yeah: Big thanks to the endless efforts of Jan Ruzicka for fixing the gopher protocol for for Firefox 2.0 just to seeing it removed from the browser right now.

Comment 15

[Mikko Kortelainen]

I disagree on removal. I run gopher servers daily and mozilla firefox/mozilla is only browser that is wide spread and supports it. Please dont make the wrong move.
Other wise i will have to recommend users who visit my site to use lynx or "my gcc4 fixed" version of Mosaic which i dont see so safe. Besides gopher is a fast and good protocol

-Mikko Kortelainen
gopher://xnet.fi
http://xnet.fi

Comment 16

[Gaddar Cabbar]

I'm starting to wonder if you guys have gone completely insane.
You're talking about the kind of decisions marketing and engineering specialists make in Microsoft or Apple headquarters...

Removing an integration feature in order to remove an attack vector?
This must be a joke..

Comment 17

[Mildred Ki'Lya]

Especially considering the bug is in Safari for Windows, not Firefox :/

Comment 18

[Robert Strong (they/them - no direct email)]

Especially since the vast vast majority of users never even use gopher... meh