38827 - startDownload string not localizable

Status: CLOSED FIXED

(Core :: Internationalization: Localization, defect, P3)

Description

[Allan Masri]

in /chrome/global/locale/unknownContent.dtd, the string startDownload is a raw 
string that needs to be made into a formatted string so it can be localized.

Comment 1

[Peter Trudelle]

[nsbeta2+]

Comment 2

[Bill Law]

This was sort of fixed originally (modulo a bug that prevented it working as it 
should have) but it got changed/broken.  I'll put it back the way it was and 
ensure the blocking bug has been resolved.

Comment 3

[Bill Law]

I have a fix for this, waiting for review.

Comment 4

[Steve Lamm]

To fix looks good to me. I tried moving the content type around and it worked
fine.

I noticed that there are two unknownContent.xul files in the tree, 

   xpfe/components/ucth/resources/unknownContent.xul (current)
   xpfe/browser/resources/content/unknowContent.xul (old?)

Should the one in xpfe/browser be removed?

Comment 5

[don]

Check it in.

Comment 6

[Bill Law]

Fix checked in.

Comment 7

[Teruko Kobayashi]

Rob, please verify this.  If you need a question, please ask Allan.

Comment 8

[Rob Spain]

in build 2000060908 M-17 branch

entity helpText is a string fragment that should have a formatted string 
variable.
should read "You are about to download a file of type %S"

this string is still not localized. reopening bug

Comment 9

[Rob Spain]

the only thing that has been fixed on this so far was an alleged blocking bug. 
The original problem has still not been addressed. The original problem was a 
string found in 
/chrome/global/locale/unknownContent.dtd 
the string reads.
<startDownload ...."You are about to download a file of type">
it needs to be changed to read
<startDownload ...."You are about to download a file of type %s">
so that it could be used on localized versions of the browser,

Comment 10

[Allan Masri]

I'm sorry I didn't make this clear in the first place. Maybe this will help.

When localizing a string, such as startDownload, we can't assume that the target 
language has the same word order as English. Therefore, the full string needs to 
be in the properties file, including a string format variable.

"You are about to download a file of type" is incorrect because the type of file 
is not included in the string, and the programmer assumes that it will be 
grammatically correct simply to tack the file type onto the end of the sentence. 

"You are about to download a file of type %s" is correct, because the variable 
%s may be placed wherever the target language's word order requires--usually 
somewhere in the middle of the string.

Comment 11

[Bill Law]

I really did fix this, as I claimed, except only for Mozilla.  There is another 
copy of the .dtd file in question in the commercial build.  I've now fixed 
that one as well.  The JS code that I checed into the Mozilla tree works for 
both.

Comment 12

[Allan Masri]

verified fixed with 7/18 netscape 6 build

Comment 13

[Rob Spain]

The string in question now reads:

<!ENTITY startDownload  "You are about to download a file of type #1.">

The patch is working. The string is now localizable.  

Closing bug