388314 - extend nsINavHistoryService interface to allow for efficient previousVisitCount() for page info

Status: RESOLVED INACTIVE

(Firefox :: Bookmarks & History, defect)

Description

[(not reading, please use [e-mail] instead)]

extend nsINavHistoryService interface to allow for efficient previousVisitCount() for page info.

see bug #388243 for details.

note, we need something efficient for "how many times before today have I visited domain X" (not URI X). 

I think we want the query to be:

SELECT count(*) FROM moz_places h JOIN moz_historyvisits v
ON h.id = v.place_id WHERE
(v.visit_date <= ?1 AND h.rev_host >= ?2 AND h.rev_host < ?2  AND h.hidden <> 1
AND v.visit_type <> 4 )

On ispiked's large places.sqlite, this is an efficient query.

Comment 1

[(not reading, please use [e-mail] instead)]

for future reference, we will also want to exclude vist_type of 0

SELECT count(*) FROM moz_places h JOIN moz_historyvisits v
ON h.id = v.place_id WHERE
(v.visit_date <= ?1 AND h.rev_host >= ?2 AND h.rev_host < ?2  AND h.hidden <> 1
AND v.visit_type <> 4 AND v.visit_type <> 0 )

Comment 2

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv

Comment 3

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.