388318 - move menu/ from /toolkit/themes/winstripe/global/ to gnomestripe

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Simon Bünzli]

... resp. completely CVS remove its content. All files are no longer needed for Winstripe because menu ornaments are now natively drawn under Windows.

Menu-arrow-*.png are still needed:
http://lxr.mozilla.org/mozilla/search?string=Menu-arrow

menu-check*.png and menu-radio*.png are not:
http://lxr.mozilla.org/mozilla/search?string=menu-check
http://lxr.mozilla.org/mozilla/search?string=menu-radio

Comment 1

[Simon Bünzli]

Attachment: adjusted jar.mn

Comment 2

[[e-mail]]

Comment on attachment 272511 [details] [diff] [review]
adjusted jar.mn

Sorry, but I don't do toolkit themes.

Comment 3

[Asaf Romano (gone)]

Comment on attachment 272511 [details] [diff] [review]
adjusted jar.mn

r=mano.

Comment 4

[Nickolay_Ponomarev]

Does this need approval?

Also, what manipulations should be done when checking in? Just cvs remove one set of files and cvs add them elsewhere? If you want cvs moves, you need a separate bug requesting that...

Also if you listed the moves explicitly, there would be lower chance that I mess them up :)

Comment 5

[Simon Bünzli]

You can CVS remove all files in toolkit/themes/winstripe/global/menu/
and add the following files to toolkit/themes/gnomestripe/global/menu/ (where the last subdirectory has to be created first):

toolkit/themes/winstripe/global/menu/Menu-arrow-disabled-rtl.png
toolkit/themes/winstripe/global/menu/Menu-arrow-disabled.png
toolkit/themes/winstripe/global/menu/Menu-arrow-hover-rtl.png
toolkit/themes/winstripe/global/menu/Menu-arrow-hover.png
toolkit/themes/winstripe/global/menu/Menu-arrow-rtl.png
toolkit/themes/winstripe/global/menu/Menu-arrow.png

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 272511 [details] [diff] [review]
adjusted jar.mn

This doesn't need approval.

Comment 7

[Reed Loden [:reed]]

Checking in toolkit/themes/gnomestripe/global/jar.mn;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/jar.mn,v  <--  jar.mn
new revision: 1.14; previous revision: 1.13
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/global/menu/Menu-arrow-disabled-rtl.png,v
done
Checking in toolkit/themes/gnomestripe/global/menu/Menu-arrow-disabled-rtl.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/menu/Menu-arrow-disabled-rtl.png,v  <--  Menu-arrow-disabled-rtl.png
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/global/menu/Menu-arrow-disabled.png,v
done
Checking in toolkit/themes/gnomestripe/global/menu/Menu-arrow-disabled.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/menu/Menu-arrow-disabled.png,v  <--  Menu-arrow-disabled.png
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/global/menu/Menu-arrow-hover-rtl.png,v
done
Checking in toolkit/themes/gnomestripe/global/menu/Menu-arrow-hover-rtl.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/menu/Menu-arrow-hover-rtl.png,v  <--  Menu-arrow-hover-rtl.png
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/global/menu/Menu-arrow-hover.png,v
done
Checking in toolkit/themes/gnomestripe/global/menu/Menu-arrow-hover.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/menu/Menu-arrow-hover.png,v  <--  Menu-arrow-hover.png
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/global/menu/Menu-arrow-rtl.png,v
done
Checking in toolkit/themes/gnomestripe/global/menu/Menu-arrow-rtl.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/menu/Menu-arrow-rtl.png,v  <--  Menu-arrow-rtl.png
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/global/menu/Menu-arrow.png,v
done
Checking in toolkit/themes/gnomestripe/global/menu/Menu-arrow.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/menu/Menu-arrow.png,v  <--  Menu-arrow.png
initial revision: 1.1
done
Checking in toolkit/themes/winstripe/global/jar.mn;
/cvsroot/mozilla/toolkit/themes/winstripe/global/jar.mn,v  <--  jar.mn
new revision: 1.35; previous revision: 1.34
done
Removing toolkit/themes/winstripe/global/menu/Menu-arrow-disabled-rtl.png;
/cvsroot/mozilla/toolkit/themes/winstripe/global/menu/Menu-arrow-disabled-rtl.png,v  <--  Menu-arrow-disabled-rtl.png
new revision: delete; previous revision: 1.2
done
Removing toolkit/themes/winstripe/global/menu/Menu-arrow-disabled.png;
/cvsroot/mozilla/toolkit/themes/winstripe/global/menu/Menu-arrow-disabled.png,v  <--  Menu-arrow-disabled.png
new revision: delete; previous revision: 1.2
done
Removing toolkit/themes/winstripe/global/menu/Menu-arrow-hover-rtl.png;
/cvsroot/mozilla/toolkit/themes/winstripe/global/menu/Menu-arrow-hover-rtl.png,v  <--  Menu-arrow-hover-rtl.png
new revision: delete; previous revision: 1.2
done
Removing toolkit/themes/winstripe/global/menu/Menu-arrow-hover.png;
/cvsroot/mozilla/toolkit/themes/winstripe/global/menu/Menu-arrow-hover.png,v  <--  Menu-arrow-hover.png
new revision: delete; previous revision: 1.2
done
Removing toolkit/themes/winstripe/global/menu/Menu-arrow-rtl.png;
/cvsroot/mozilla/toolkit/themes/winstripe/global/menu/Menu-arrow-rtl.png,v  <--  Menu-arrow-rtl.png
new revision: delete; previous revision: 1.2
done
Removing toolkit/themes/winstripe/global/menu/Menu-arrow.png;
/cvsroot/mozilla/toolkit/themes/winstripe/global/menu/Menu-arrow.png,v  <--  Menu-arrow.png
new revision: delete; previous revision: 1.2
done
Removing toolkit/themes/winstripe/global/menu/menu-arrow-disabled.gif;
/cvsroot/mozilla/toolkit/themes/winstripe/global/menu/menu-arrow-disabled.gif,v  <--  menu-arrow-disabled.gif
new revision: delete; previous revision: 1.2
done
Removing toolkit/themes/winstripe/global/menu/menu-arrow-hover.gif;
/cvsroot/mozilla/toolkit/themes/winstripe/global/menu/menu-arrow-hover.gif,v  <--  menu-arrow-hover.gif
new revision: delete; previous revision: 1.2
done
Removing toolkit/themes/winstripe/global/menu/menu-arrow.gif;
/cvsroot/mozilla/toolkit/themes/winstripe/global/menu/menu-arrow.gif,v  <--  menu-arrow.gif
new revision: delete; previous revision: 1.2
done
Removing toolkit/themes/winstripe/global/menu/menu-check-disabled.gif;
/cvsroot/mozilla/toolkit/themes/winstripe/global/menu/menu-check-disabled.gif,v  <--  menu-check-disabled.gif
new revision: delete; previous revision: 1.2
done
Removing toolkit/themes/winstripe/global/menu/menu-check-hover.gif;
/cvsroot/mozilla/toolkit/themes/winstripe/global/menu/menu-check-hover.gif,v  <--  menu-check-hover.gif
new revision: delete; previous revision: 1.2
done
Removing toolkit/themes/winstripe/global/menu/menu-check.gif;
/cvsroot/mozilla/toolkit/themes/winstripe/global/menu/menu-check.gif,v  <--  menu-check.gif
new revision: delete; previous revision: 1.2
done
Removing toolkit/themes/winstripe/global/menu/menu-radio-disabled.gif;
/cvsroot/mozilla/toolkit/themes/winstripe/global/menu/menu-radio-disabled.gif,v  <--  menu-radio-disabled.gif
new revision: delete; previous revision: 1.2
done
Removing toolkit/themes/winstripe/global/menu/menu-radio-hover.gif;
/cvsroot/mozilla/toolkit/themes/winstripe/global/menu/menu-radio-hover.gif,v  <--  menu-radio-hover.gif
new revision: delete; previous revision: 1.2
done
Removing toolkit/themes/winstripe/global/menu/menu-radio.gif;
/cvsroot/mozilla/toolkit/themes/winstripe/global/menu/menu-radio.gif,v  <--  menu-radio.gif
new revision: delete; previous revision: 1.2
done