Stop using exceptions as part of the normal bookmark code flow

RESOLVED FIXED in Camino1.6

Status

Camino Graveyard
Bookmarks
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Stuart Morgan, Assigned: Stuart Morgan)

Tracking

({fixed1.8.1.8})

unspecified
Camino1.6
x86
Mac OS X
fixed1.8.1.8

Details

Attachments

(1 attachment)

fix
2.28 KB, patch
Håkan Waara
: review+
Mike Pinkerton (not reading bugmail)
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

11 years ago
Per IRC, bookmarks uses exceptions to handle showing folder counts in the bookmark manager (and possibly in other non-exceptional ways). Definitely not something we should be doing.
(Assignee)

Comment 1

11 years ago
Created attachment 272646 [details] [diff] [review]
fix
Attachment #272646 - Flags: review?(nick.kreeger)
This behavior is blocking some of peeja's SoC work.

Comment 3

11 years ago
Comment on attachment 272646 [details] [diff] [review]
fix

I could r+ this, in case Nick doesn't mind.
Attachment #272646 - Flags: review+
(Assignee)

Updated

11 years ago
Attachment #272646 - Flags: review?(nick.kreeger) → superreview?(mikepinkerton)
Comment on attachment 272646 [details] [diff] [review]
fix

rs=pink
Attachment #272646 - Flags: superreview?(mikepinkerton) → superreview+
(Assignee)

Comment 5

11 years ago
Landed on trunk and MOZILLA_1_8_BRANCH.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Keywords: fixed1.8.1.7
Resolution: --- → FIXED
Target Milestone: --- → Camino1.6
You need to log in before you can comment on or make changes to this bug.