388349 - Sidebar "Tabs" menu misplaced in Suiterunner

Status: VERIFIED FIXED

(SeaMonkey :: Sidebar, defect)

Description

[Ed]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007071311 SeaMonkey/2.0a1pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007071311 SeaMonkey/2.0a1pre

When clicking on "Tabs" in the sidebar title bar in previous builds, a menu appears below the title. In Suiterunner builds however, the menu appears with the first item exactly where the cursor is, and unless the user is careful the first item gets automatically selected.

Reproducible: Always

Steps to Reproduce:
1. Open sidebar
2. Click on "Tabs"
Actual Results:  
When mouse button is pressed, menu appears with first item straight under the cursor. If the user clicks without dragging then the first item is automatically selected.

Expected Results:  
Menu should appear below the button, so that the user can select whichever item they choose to.

Comment 1

[Tobias Fischer]

I can confirm this with:
Build identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.9pre) Gecko/2008032704 Mnenhy/0.7.5.20005 SeaMonkey/2.0a1pre
(Mnenhy deactivated cause of Bug 424982)

When open the Drop-Down-Menu from "Tabs" Button in Sidebar with Mouseclick the Menu will popup, but even if there was no Item selected by User (marked blue), the Dropdown-Menu-Popup closes and first Item in List "Customize Sidebar" will be opend when mousebutton was leased. 


Error-Console gives:

Error: uncaught exception: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIRDFService.GetResource]"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: chrome://communicator/content/sidebar/sidebarOverlay.js :: SidebarTogglePanel :: line 1269"  data: no]


To select other then the first Menu-Item, I have to hold the Mousebutton pressed while move down in Menu-Popup. 

Comment 2

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008060902 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

(Bug still there.)

***

(In reply to comment #1)
> Error: uncaught exception: [Exception... "Component returned failure code:
> 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIRDFService.GetResource]"  nsresult:
> "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame ::
> chrome://communicator/content/sidebar/sidebarOverlay.js :: SidebarTogglePanel
> :: line 1269"  data: no]

Bug 412221 ;-)

Comment 3

[Philip Chee]

Attachment: Fix 1.0: replace |popupanchor="bottomleft"| with |position="after_start"|

I fixed this sometime back in the xSidebar extension. Porting my fix to SeaMonkey 2.0a

Comment 4

[[e-mail]]

Comment on attachment 346035 [details] [diff] [review]
Fix 1.0: replace |popupanchor="bottomleft"| with |position="after_start"|

Actually "after_start" is the default (see nsXULPopupManager::ShowMenu) so you could just omit this line completely.

Comment 5

[Philip Chee]

Attachment: Fix 1.1: remove popupanchor completely [Checkin: Comment 6]

Carrying forward r+/sr+

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 346051 [details] [diff] [review]
Fix 1.1: remove popupanchor completely
[Checkin: Comment 6]

http://hg.mozilla.org/comm-central/rev/80121b0303a5

Comment 7

[Serge Gautherie (:sgautherie)]

And
{
http://hg.mozilla.org/comm-central/rev/47e9e30342e6
Windows bustage fix
}
Thanks to Magnus.

Comment 8

[Philip Chee]

nani nani?

Comment 9

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b2pre) Gecko/20081105 SeaMonkey/2.0a2pre] (nightly) (W2Ksp4)

V.Fixed