388523 - ###!!! ASSERTION: null request in stream complete handler: 'request', file nsScriptLoader.cpp, line 791

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Mats Palmgren (inactive)]

Attachment: stack for the assertion

STEPS TO REPRODUCE
see bug 380512

ACTUAL RESULTS
###!!! ASSERTION: null request in stream complete handler: 'request', file nsScriptLoader.cpp, line 791

Comment 1

[Boris Zbarsky [:bzbarsky]]

So this is an HTTP bug, I think.  The problem is that nsHttpChannel::OnStartRequest poses the auth dialog.  While this dialog is up, the underlying nsInputStreamPump is canceled with NS_BINDING_ABORTED.  The user selects "OK" in the dialog, so HTTP needs to do an auth retry.  It does NOT call OnStartRequest on its listener, and returns from nsHttpChannel::OnStartRequest.

Now in nsInputStreamPump::OnStateStart we have mStatus == NS_BINDING_ABORTED, so the stream pump's loop in OnInputStreamReady calls OnStateStop, which calls nsHttpChannel::OnStopRequest.  The HTTP channel passes this stop through to its listener... but the listener never got an OnStartRequest.  In this case, the listener stores some state in OnStartRequest to use in OnStopRequest, so things don't work out.

We can fix this by checking mCanceled after calling GetCredentials() or calling ProcessAuthentication(), but should we instead just make sure we call OnStartRequest in nsHttpChannel::OnStopRequest if we haven't called it yet?  Seems more robust.

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 275530 [details] [diff] [review]
patch

Makes sense.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in nsHttpChannel.cpp;
/cvsroot/mozilla/netwerk/protocol/http/src/nsHttpChannel.cpp,v  <--  nsHttpChannel.cpp
new revision: 1.316; previous revision: 1.315
done