388524 - Partial / Complete Updates on "Beta" Channel doesn't correctly handle rc2, rc3, ...

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[Carsten Book [:Tomcat]]

Currently 2.0.0.4 users should get partial updates to 2.0.0.5

When users are on the beta channel, they will only get served a complete update from 2.0.0.4 to 2.0.0.5 not the normal partial. 

This regressed between 2.0.0.4/2.0.0.5 since the update for 2.0.0.3->2.0.0.4 on the beta channel is partial.

Comment 1

[J. Paul Reed [:preed]]

The issue here is that DisableCompleteUpdateJump isn't set to 1 when the patcher config gets bumped.

The logic here works like:

if (rc == 1) {
  ... publish test snippets pointing to partial/complete mars as normal ...
} else (rc > 1) {
  ... publish test snippets as normal, but for rc1 builds, publish complete mars for both partials and complete, because we don't create mars from RC builds to RC builds.
}

This is just an oversight in the automation.

Comment 2

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Havent been able to look at this, so returning it to the pool.

Comment 3

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

We just hit this problem again with 2007rc2 on the beta channel. 

1) this problem only occurs on "beta" channel. It does not occur on "betatest" or "release" or "releasetest" channels

2) When doing "rc1", then the correct "partial updates from previous release" are pushed to the beta channel. 

3) When doing "rc2" or later, we should be doing the same. However, we instead push "full updates". The confusion here is that we correctly do not generate or distribute partial updates from rc1 -> rc2 -> rc3, etc. It seems like if people on "beta" are on previous release, then they should get a partial update? But if people on "beta" are on a previous rc of the current release, they should get a full update? Do we even support people on "beta" even using a previous rc of the current release?


Updated subject accordingly.

Comment 4

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

4) If "betatest" and "beta" are supposed to be identical, how come this is only a problem with "beta", and not with "betatest"?

Comment 5

[Marcia Knous [:marcia]]

I see this during my update testing on Mac, going from 2.0.0.7->2.0.0.8rc2. I get the full update, and is pretty big on the mac.

Comment 6

[Robert Helmer [:rhelmer]]

Attachment: disable complete jump should be in <rc> section

Took a look through the code, DisableCompleteJump is expected in the channel section. It looks like testchannels are done totally differently, which is why betatest does not have this problem while beta does.

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 300908 [details] [diff] [review]
disable complete jump should be in <rc> section

r+. Please fix the same problem in the Thunderbird config when you check in.

Comment 8

[Robert Helmer [:rhelmer]]

Attachment: [checked in] disable complete jump should be in <rc> section [as landed]

Checking in moz18-branch-patcher2.cfg;
/cvsroot/mozilla/tools/patcher-configs/moz18-branch-patcher2.cfg,v  <--  moz18-branch-patcher2.cfg
new revision: 1.4; previous revision: 1.3
done

Comment 9

[Robert Helmer [:rhelmer]]

Ok, regenerating AUS config for 2.0.0.12, so we can stop tripping on this.

Comment 10

[Nick Thomas [:nthomas] (UTC+12)]

PatcherConfig undid this change for rc4. Looks like this is the culprit:
http://mxr.mozilla.org/seamonkey/source/tools/release/Bootstrap/Step/PatcherConfig.pm#156

Comment 11

[Robert Helmer [:rhelmer]]

Attachment: [checked in] oops i did it again

Comment 12

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 301143 [details] [diff] [review]
[checked in] oops i did it again

:-)

Comment 13

[Robert Helmer [:rhelmer]]

Attachment: [checked in] more permanent fix

For some reason this feature is implemented as a "channel" in patcher. I supposed we could expand it to selectively jump certain RCs, but neither patcher nor Bootstrap::Step::PatcherConfig could handle that currently.

It only seems to matter that DisableCompleteJump "channel" is set to non-zero, so I think simply adding it to the RC channels will do the trick.

Comment 14

[Robert Helmer [:rhelmer]]

Comment on attachment 301143 [details] [diff] [review]
[checked in] oops i did it again

Checking in moz18-branch-patcher2.cfg;
/cvsroot/mozilla/tools/patcher-configs/moz18-branch-patcher2.cfg,v  <--  moz18-branch-patcher2.cfg
new revision: 1.6; previous revision: 1.5
done

Comment 15

[Robert Helmer [:rhelmer]]

Comment on attachment 301144 [details] [diff] [review]
[checked in] more permanent fix

Checking in Bootstrap/Step/PatcherConfig.pm;
/cvsroot/mozilla/tools/release/Bootstrap/Step/PatcherConfig.pm,v  <--  PatcherConfig.pm
new revision: 1.15; previous revision: 1.14
done