388566 - Set a minimum width for calendar and mode toolbar icons

Status: VERIFIED FIXED

(Calendar :: Lightning Only, defect)

Description

[Simon Paquet [:sipaq]]

Both Firefox and Thunderbird set minimum-width for their toolbar icons and after discussion with Christian, I think that such a minor change would improve our UI.

Comment 1

[Simon Paquet [:sipaq]]

Attachment: Calendar toolbar without min-width

Comment 2

[Simon Paquet [:sipaq]]

Attachment: Calendar toolbar with min-width 50px

Comment 3

[Simon Paquet [:sipaq]]

Attachment: Mode toolbar without min-width

Comment 4

[Simon Paquet [:sipaq]]

Attachment: Mode toolbar with min-width 50px

Comment 5

[Simon Paquet [:sipaq]]

Attachment: Patch v1

Comment 6

[Christian Jansen]

Comment on attachment 272788 [details]
Patch v1

Looks good for me. Thanks for the work :-)

Comment 7

[Christian Jansen]

ui-review=Chris

Comment 8

[Simon Paquet [:sipaq]]

Patch checked in.

Comment 9

[Stefan Sitter [:ssitter]]

This patch is either incomplete or faulty because it wrecks the icon only mode.

Comment 10

[Stefan Sitter [:ssitter]]

Attachment: icon only mode

Screenshot for the icon only mode. Without the patch the icon size is the same on mail and calendar toolbar. With the patch the icons on calendar toolbar are to wide.

Comment 11

[Stefan Sitter [:ssitter]]

Simon, can you point me to the location where Firefox and Thunderbird set the minimum-width for their toolbar icons? 

On a quick search I only found <http://lxr.mozilla.org/mozilla1.8/source/mail/themes/qute/mail/messenger.css#101> and <http://lxr.mozilla.org/mozilla1.8/source/browser/themes/winstripe/browser/browser.css#261>. But this is a different width. 

It also seems that there is nothing similar for the pinstripe theme.

Comment 12

[Simon Paquet [:sipaq]]

I wouldn't call this wrecking the icon-only mode, but I agree that the current solution is not optimal. We should probably introduce a 

  toolbar[mode="full"] .cal-toolbarbutton-1 {

statement, to which we assign the min-width: 50px
Feel free to supply a patch on this. I'll probably not get to this before the weekend.

Comment 13

[Stefan Sitter [:ssitter]]

Attachment: win32 Thunderbird toolbar uses min-width 55px

This image shows the main Thunderbird toolbar on Windows. It is measurable that the min. width is 55px. This matches the link in Comment #11.

-> For Lightning (winstripe theme) the min. width should be 55px (not 50px) but only for "full" mode.

As also said in Comment #11 I did not saw a similar setting in the pinstripe theme. Could someone provide a similar screenshot for the MacOS X build of Thunderbird or could point to the source?

Comment 14

[Simon Paquet [:sipaq]]

The patch in bug 388016 will fix this bug.

Comment 16

[Simon Paquet [:sipaq]]

Fixed by the checkin for bug 388016.

Comment 17

[Simon Paquet [:sipaq]]

I accidentally added a "min-width: 0" statement to the section for the small calendar mode toolbar. I've reverted that change. Sorry for messing things up!

Comment 18

[Stefan Sitter [:ssitter]]

(In reply to comment #17)

The rule for small toolbar buttons had "min-width: 0px;" set before you changed it to "min-width: 50px;". (See you patch in this bug) In my opinion the "min-width: 0px;" should be added back as also commented in Bug 388016 Comment #30.

Comment 19

[Simon Paquet [:sipaq]]

I don't think, that the rule should be added back. The reason is, that this would create an inconsistency between Thunderbird and Lightning.

Just try to switch between large and small icon+text mode in the mail toolbar and then in the calendar toolbar with and without the "min-width: 0px". 

In the mail toolbar the icons just vary their height. The calendar toolbar without the "min-width: 0px" is doing the same, without the "min-width: 0px" the icons get crammed together and move to the right. 

I don't think that we should have such inconsistencies in our UI if we can avoid them.

Comment 20

[Andreas Treumann]

Verified in latest nightly build 20080108 -> task is fixed.