388601 - Can't drag from history sidebar to bookmarks toolbar, sourceView shouldn't be null

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Christine Yen]

As seen in comments in bug 364298, sourceView is null when the onDrop() method is called in controller.js , and it doesn't seem like it should be.

Comment 1

[Christine Yen]

Attachment: sourceView shouldn't be null

This patch forces the boolean "copy" to true when dragging from a read-only container, but fails when DnD to the toolbar, where sourceView is null upon DnD.

Comment 2

[Christine Yen]

Attachment: patch

Is there a reason sourceView was being set as null in toolbar.xml's onDrop? Is it simply because it's not necessary/because it works fine without passing controller.js an actual sourceView? Hmm... Either way, this works fine now.

Comment 3

[(not reading, please use [e-mail] instead)]

Comment on attachment 275674 [details] [diff] [review]
patch

re-assign review to dietrich.

this bug has been bit rotting in my review queue for a while.

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

after recent fixes this is actually WFM, at least on Windows. Most probably due to recent cleanup made on that code (PlacesControllerDragHelper.onDrop now takes only an insertionPoint) by Bug 412148. 
marking as fixed by that bug.

Comment 5

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv