388695 - getBookmarkIdsForURI should sort by relevance

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Asaf Romano (gone)]

Attachment: patch

getBookmarkIdsForURI should sort by relevance.

For the time being, this means sorting by last-modified or date-added (descending)

Comment 1

[Dietrich Ayala (:dietrich)]

you could do something like this:

select id, max(recent) from (select id, lastModified as recent from moz_bookmarks UNION select id, dateAdded as recent from moz_bookmarks order by 2 DESC)

Comment 2

[Asaf Romano (gone)]

Attachment: patch

you'd think sql maps NULL to 0 when comparing, you'd.

Comment 3

[Asaf Romano (gone)]

mozilla/toolkit/components/places/src/nsNavBookmarks.cpp 1.110
mozilla/toolkit/components/places/tests/bookmarks/test_bookmarks.js 1.31
mozilla/toolkit/components/places/tests/unit/test_tagging.js 1.2

Comment 4

[Asaf Romano (gone)]

Attachment: tests fix (checked in)

Comment 5

[Asaf Romano (gone)]

backed-out, these tinderboxes still know nothing about date & time.

Comment 6

[Marco Bonardo [:mak]]

imho if you need only to get ids you could put the max into order by clause:

       SELECT b.id
       FROM moz_bookmarks b
       JOIN moz_places p ON b.fk = p.id
       WHERE p.url = ?1
       AND b.type = ?2
       ORDER BY MAX(COALESCE(b.lastModified, 0), b.dateAdded) DESC

this should have less memory usage on results

Comment 7

[Asaf Romano (gone)]

Attachment: patch v2

* comment 6
* timeout-based tests for this method, so it passes on the VMs.
* use sort() otherwise in tests
* making getTagsForURI return a sorted list

Comment 8

[Asaf Romano (gone)]

mozilla/browser/components/places/tests/unit/test_placesTxn.js 1.4
mozilla/toolkit/components/places/public/nsITaggingService.idl 1.2
mozilla/toolkit/components/places/src/nsNavBookmarks.cpp 1.112
mozilla/toolkit/components/places/src/nsTaggingService.js 1.2
mozilla/toolkit/components/places/tests/bookmarks/test_388695.js 
initial revision: 1.1
mozilla/toolkit/components/places/tests/bookmarks/test_bookmarks.js 1.34

Comment 9

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv