388712 - [FIXr]"ASSERTION: Walked too far?" with html:form, html:label, and svg:use

Status: RESOLVED FIXED

(Core :: SVG, defect, P2)

Description

[Jesse Ruderman]

Attachment: testcase (reload to see the assertion)

To trigger the assertion, close or reload the testcase.

###!!! ASSERTION: Walked too far?: 'nsContentUtils::IsInSameAnonymousTree(this, content)', file /Users/jruderman/trunk/mozilla/content/html/content/src/nsGenericHTMLElement.cpp, line 1244

The assertion was added yesterday in bug 388386.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Hmm.  So we have anonymous content like so:

 <form><label></form>

and we're unbinding the whole thing.  The behavior here is still right (we're walking to the right place, that being the form, when the label is unbound), but the assertion is failing because the form has already been unbound and hence has a null binding parent.

I guess what I'll do is restore the IndexOf() checks for this case, debug-only.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Like so

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 272899 [details] [diff] [review]
Like so

Debug-only change to prevent incorrect assertions and make Jesse's testing yet more peaceful.  Risk is basically none.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 272899 [details] [diff] [review]
Like so

a19=dbaron

Comment 5

[Boris Zbarsky [:bzbarsky]]

Fixed.

Comment 6

[Jesse Ruderman]

Crashtest checked in.