rewrite config.guess / config.sub in Python

RESOLVED FIXED in mozilla2.0

Status

Firefox Build System
General
RESOLVED FIXED
11 years ago
3 months ago

People

(Reporter: ted, Assigned: ted)

Tracking

unspecified
mozilla2.0

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

11 years ago
As part of our configure system rewrite, we're going to rewrite portions of the configure system in Python.  config.guess and config.sub are nice, standalone scripts.  We don't intend to produce a complete port, these scripts support a huge amount of legacy architectures that we've never supported.  We'll support a basic subset, and port maintainers can add support for others.
(Assignee)

Comment 1

11 years ago
Created attachment 273110 [details] [diff] [review]
Replace config.guess

This config.guess replacement handles Windows (MSYS/Cygwin), Linux, OS X, and Solaris x86.  I've verified that it produces identical output on all the platforms I have access to.  (Basically everything but Mac PPC, but I poked at the Python library, and I think I got it right there.)

I didn't add a license header to guess.py, I still need to do that.
Attachment #273110 - Flags: review?(benjamin)
(Assignee)

Comment 2

11 years ago
Comment on attachment 273110 [details] [diff] [review]
Replace config.guess

I'll have a newer patch soon.
Attachment #273110 - Attachment is obsolete: true
Attachment #273110 - Flags: review?(benjamin)
(Assignee)

Comment 3

11 years ago
Created attachment 273411 [details] [diff] [review]
replace config.guess and config.sub

Ok, this replaces both config.guess and config.sub.  The shell scripts are reduced to one-liners calling the python script.  The python script behaves like config.guess if no arguments are given, and config.sub if one argument is given.
Attachment #273411 - Flags: review?(benjamin)
(Assignee)

Updated

11 years ago
Attachment #273411 - Attachment is patch: true
Attachment #273411 - Attachment mime type: application/octet-stream → text/plain

Comment 4

11 years ago
Comment on attachment 273411 [details] [diff] [review]
replace config.guess and config.sub

The dictionary-keyed-with-strings-or-regexes looks a little odd to me, and I expect that we'll have to abstract that away in the future, but I guess it's ok for now.

We should switch to calling guess.py directly from the configure script ASAP.
Attachment #273411 - Flags: review?(benjamin) → review+
(Assignee)

Comment 5

11 years ago
Pushed to branch.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Assignee)

Comment 6

11 years ago
Created attachment 275612 [details] [diff] [review]
use guess.py in autoconf macros

Pretty simple patch.
Attachment #275612 - Flags: review?(benjamin)

Updated

11 years ago
Attachment #275612 - Flags: review?(benjamin) → review+
(Assignee)

Comment 7

11 years ago
Comment on attachment 275612 [details] [diff] [review]
use guess.py in autoconf macros

Pushed to 2007-configure-rewrite

Updated

3 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.