Closed Bug 388794 Opened 12 years ago Closed 11 years ago
[FIX]No x/y coords sent when an image input without an image frame is triggered
Could you provide a minimal html testcase (as attachment)?
Here, the page take a long time after I pressed "next" but results are displayed fine. Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:22.214.171.124) Gecko/20070713 Firefox/126.96.36.199 ID:2007071317
Component: Disability Access → Layout: Form Controls
Product: Firefox → Core
QA Contact: disability.access → layout.form-controls
Version: 2.0 Branch → 1.8 Branch
Reporter: have you tested this with a recent version of Firefox 3 test builds? http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-trunk/
regis someone had switched the server to an old version. now you can look at the problem in the attachment you can see the alt of the imagebuttons that don' t work. i have also tested it in firefox 3 but nothing happend.. the problem still remains.. when you click next nothing happens... test in ie to see the difference.. Thanks
I think your onclick -- i.e. "ShowLoad()" -- for the image relies on a blocked script (because JS is disabled)
i know that and that's what i don't how come it doesn't work if you disable images or js but if you disable them both it doesn't work...
Here, it works only when image are displayed whatever is JS status Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007072205 Minefield/3.0a7pre ID:2007072205 Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:188.8.131.52) Gecko/20070713 Firefox/184.108.40.206 ID:2007071317 -> updating summary
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: imagebutton does not work → image onclick doesn't work when "Load image automatically" is disabled
Régis, can you possibly attach the HTML page that shows the problem to the bug, if you can reproduce it? The server at test.bookcyprus.com is not responding when I try to access it.... Is the problem just that no x/y coordinates are sent when submitting using an image input that got replaced by alt text and that the server expects to get x/y in this case and fails if it doesn't? Does tabbing to the input and then hitting enter fail the same way?
(In reply to comment #13) > Régis, can you possibly attach the HTML page that shows the problem to the > bug, if you can reproduce it? The server at test.bookcyprus.com is not > responding when I try to access it.... It seems the bug relies on the dynamic part of the site, so I will attech the generated HTML but I can't reproduce with it > Is the problem just that no x/y coordinates are sent when submitting using an > image input that got replaced by alt text and that the server expects to get > x/y in this case and fails if it doesn't? Does tabbing to the input and then > hitting enter fail the same way? The x/y solution looks probable to me (what is strange is that reporter said it works with Opera..), changing a select value (there is no edit) make the form works as expected. PS: URL WFM
Attachment #276255 - Attachment mime type: application/octet-stream → application/zip
Uh... So the attached files have a disabled "next" link (since there is only one page of results). The URI in comment 4 gives no results at all. Can someone give me actual steps to reproduce this bug?
OK, I've gotten the site at http://test.bookcyprus.com to respond, and turning off images just makes the prev/next buttons disappear because they have alt="" set (who designed this site anyway?). So again: How do I reproduce this bug?
I can: 1/ load http://test.bookcyprus.com 2/ click "Next" 3/ disable image in FF options 4/ refresh the page 5/ load DOMi, click "find a node" 6/ click the "xx records | page 1 /2| |" 7/ lookup for <INPUT src="../Images/nextOn_1.gif" .. 8/ set its alt text to "next" 9/ click "next" on the bookcyprus page that's all: you still are on the page 1 and not on the page 2 NB: Sorry about the DOMi steps but the test url don't have any alt text anymore..
Régis, thank you. That does the trick! Changing our code to pass "x=0&y=0" instead of "x=&y=" when there is no image does in fact fix the test site. Opera passes those when the image control is triggered by enter if the image is visible, and passes click coordinates when clicking on the alt text. We pass "x=0&y=0" when the image control is triggered by enter if the image is visible. See bug 122238 for the discussion that led to us implementing our current behavior. Since we've had this behavior since early 2004, and this is the first bug report on it that I see, I'm tempted to claim this is a bug in the site... If we decide we do care, sending x=0&y=0 is pretty easy. Under no circumstances should we do what Opera does. In any case, not a layout issue at all.
Component: Layout: Form Controls → DOM: HTML
QA Contact: layout.form-controls → general
Boris, thanks for your detailled answer.
Flags: blocking1.9? → blocking1.9-
> Not a blocker since this isn't a regression Actually, it's a regression from 1.7 in a lot of cases: we used to show a broken image placeholder in a lot more cases than we do now. > At this point i'm also very confused what is the actual problem here. Resummarized to make it clear.
Summary: image onclick doesn't work when "Load image automatically" is disabled → No x/y coords sent when an image input without an image frame is triggered
HTML5 says to send 0,0.
Summary: No x/y coords sent when an image input without an image frame is triggered → [FIX]No x/y coords sent when an image input without an image frame is triggered
Pushed changeset 3e39748e01cd.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.