Closed
Bug 388826
Opened 18 years ago
Closed 18 years ago
"cannot make a conclusive match" should not be said if the only reason is confirmuniqueusermatch
Categories
(Bugzilla :: User Interface, enhancement)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.2
People
(Reporter: timeless, Assigned: timeless)
References
()
Details
Attachments
(1 file)
|
2.04 KB,
patch
|
wicked
:
review+
|
Details | Diff | Splinter Review |
bugs.maemo.org is using confirmuniqueusermatch (I recommended against it, but I was overruled).
steps to reproduce:
try to reassign a bug to yourself but omit the last character from your login name.
Actual Results:
Bugzilla cannot make a conclusive match for one or more of the names and/or email addresses you entered on the previous page.
Please examine the lists of potential matches below and select the one you want, or go back to the previous page to revise the names you entered.
Assignee: timeless@gmail.co matched timeless <timeless@gmail.com>
[ Continue ]
Expected results:
Since there's a unique match and the only reason for the confirm screen is confirmuniqueusermatch, the page shouldn't mention:
Bugzilla cannot make a conclusive match for one or more of the names and/or email addresses you entered on the previous page.
--
I've made one change to the English for the normal path
select the one you want => select the ones you want
Ideally the template would be able to know to use one or ones (and other things), but that's hard and should be done as some other general number bug.
Attachment #272995 -
Flags: review?(wicked)
Updated•18 years ago
|
Summary: conclusive match message should not be shown if the only reason is confirmuniqueusermatch → "cannot make a conclusive match" should not be said if the only reason is confirmuniqueusermatch
Updated•18 years ago
|
Attachment #272995 -
Flags: review?(wicked) → review+
Updated•18 years ago
|
Flags: approval?
OS: Windows XP → All
Hardware: PC → All
Target Milestone: --- → Bugzilla 3.2
Updated•18 years ago
|
Status: NEW → ASSIGNED
Flags: approval? → approval+
Comment on attachment 272995 [details] [diff] [review]
changes
mozilla/webtools/bugzilla/Bugzilla/User.pm 1.157
mozilla/webtools/bugzilla/template/en/default/global/confirm-user-match.html.tmpl 1.18
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•