388920 - EXTENSIONS_ALL broken since webservices was removed

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Robert Sayre]

since schema-validation depends on webservices. what a tangled web we weave.

Comment 1

[Robert Sayre]

Attachment: make schema-validation in EXTENSIONS_ALL contingent on webservices

Comment 2

[Steffen Wilberg]

So MOZ_EXTENSIONS_ALL lists every extension out there. Developers using that want to see if everything still builds and works. That's why xforms and schema-validation is listed there as well. But both depend on webservices. Since webservices is no longer built by default, xforms and now schema-validation get removed from that list. That doesn't make sense.

Either remove xforms and schema-validation from MOZ_EXTENSIONS_ALL, or add webservices to it.

By the way, this is wrong as well:
5452 if test `echo "$MOZ_EXTENSIONS" | grep -c webservices` -ne 0; then
5453   AC_MSG_WARN([webservices is no longer an extension, use --disable-webservices to disable.])
5454   MOZ_EXTENSIONS=`echo $MOZ_EXTENSIONS | sed -e 's|webservices||g'`
5455 fi

Comment 3

[aaronr]

We (xforms and schema-validation) are working on removing our webservices dependency by moving the schema loader stuff we need into the schema-validation extension.  So hopefully this issue will go away eventually anyhow.  But I would personally expect MOZ_EXTENSIONS_ALL to build ALL the extensions in the tree, whether they build by default or not.  So I would have thought that MOZ_EXTENSIONS_ALL would build webservices, schema-validation and xforms as well as the other extensions.

Comment 4

[Robert Sayre]

None of the people who contacted me on IRC to report broken builds cared if MOZ_EXTENSIONS_ALL included xforms and schema-validation. Neither do I. schema-validation needed a dependency on webservices, just like xforms, and I implemented it identically.

If you want MOZ_EXTENSIONS_ALL to include these extensions, feel free to make the needed changes and request review from Ted or Benjamin. That's a different bug, though.

Comment 5

[Boris Zbarsky [:bzbarsky]]

> None of the people who contacted me on IRC to report broken builds cared

Actually, I do care, for the exact reasons Steffen lists -- I need to make sure that API changes I make don't break parts of the tree.  I enabled webservices locally so things all build.  That's less important to me than things building, though, and since so many people in fact don't care if their changes break anything other than Firefox it's a losing battle.

Comment 6

[Robert Sayre]

(In reply to comment #5)
> > None of the people who contacted me on IRC to report broken builds cared
> 
> Actually, I do care, for the exact reasons Steffen lists

OK, I must have misunderstood you. That's fine. Please file a new bug for enhancements to the build system. This bug is closed, and I can't un-CC myself.