389021 - dumpdata crashes when no id provided

Status: RESOLVED FIXED

(Webtools Graveyard :: Graph Server, defect)

Description

[alice nodelman [:alice] [:anode]]

Attachment: fix for dumpdata.cgi crash

This small patch fixes this error when dumpdata.cgi is run with no inputs.

Traceback (most recent call last):
  File "/var/www/html/graphs/dumpdata.cgi", line 111, in ?
    dumpData(zfile, setid, starttime, endtime)
  File "/var/www/html/graphs/dumpdata.cgi", line 56, in dumpData
    cur.execute("SELECT B.id, B.machine, B.branch, B.test, B.date FROM dataset_info as B WHERE id IN (%s) %s %s ORDER BY id" % (setid, s1, s2,))
  File "/var/www/html/graphs/databases/mysql.py", line 16, in execute
    return MySQLdb.cursors.Cursor.execute(self, query, args)
  File "/usr/lib/python2.4/site-packages/MySQLdb/cursors.py", line 163, in execute
    self.errorhandler(self, exc, value)
  File "/usr/lib/python2.4/site-packages/MySQLdb/connections.py", line 35, in defaulterrorhandler
    raise errorclass, errorvalue
ProgrammingError: (1064, "You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')   ORDER BY id' at line 1")

Comment 1

[Reed Loden [:reed]]

Checking in dumpdata.cgi;
/cvsroot/mozilla/webtools/new-graph/dumpdata.cgi,v  <--  dumpdata.cgi
new revision: 1.3; previous revision: 1.2
done