Closed
Bug 389110
Opened 18 years ago
Closed 18 years ago
A few last warning fixes
Categories
(Camino Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: stuart.morgan+bugzilla, Assigned: stuart.morgan+bugzilla)
Details
(Keywords: fixed1.8.1.8)
Attachments
(1 file)
|
4.14 KB,
patch
|
mark
:
superreview+
|
Details | Diff | Splinter Review |
This fixes all the rest of the warnings I see doing a clean trunk debug build of all the Camino code, except for the bogus enumeral mismatch warnings from the gcc bug. (Arguably changing a #warning to a TODO: isn't really fixing it, but I'd rather not have us using #warning for minor things like that).
Attachment #273264 -
Flags: superreview?(mark)
|
||
Comment 1•18 years ago
|
||
Comment on attachment 273264 [details] [diff] [review]
fix
+ if (rowIndex != -1 && rowIndex < (int)[mCertificatesData count])
Wouldn't this be better if rowIndex were casted to an unsigned int in the second term?
|
Assignee | |
Comment 2•18 years ago
|
||
Sure, I can change that on checkin (although if we ever have more than INTMAX rows, we probably have other problems ;) )
|
|
||
Updated•18 years ago
|
Attachment #273264 -
Flags: superreview?(mark) → superreview+
|
|
Assignee | |
Comment 3•18 years ago
|
||
Landed on trunk and MOZILLA_1_8_BRANCH.
You need to log in
before you can comment on or make changes to this bug.
Description
•