Closed
Bug 389141
Opened 17 years ago
Closed 17 years ago
Remove the "ad-blocking in userContent cleanup" code
Categories
(Camino Graveyard :: Annoyance Blocking, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Camino1.6
People
(Reporter: alqahira, Assigned: stuart.morgan+bugzilla)
Details
(Keywords: fixed1.8.1.6)
Attachments
(1 file)
|
2.58 KB,
patch
|
mark
:
superreview+
|
Details | Diff | Splinter Review |
For a little while in the 0.9a era, we shoved our ad-blocking into userContent.css (it was a dark and ugly era, and we want to forget it). After we moved to the stylesheet service, we had to add some code to clean up our mess (which then annoyed real userContent.css users all over again).
0.9a is sufficiently far in the past (1.0 and 1.5 have both shipped) that we can remove the cleanup code.
It looks like there are 3 "blocks" of code in PreferenceManager.mm that handle cleanupUserContentCSS
|
Reporter | |
Updated•17 years ago
|
Whiteboard: [good first bug]
|
Assignee | |
Comment 1•17 years ago
|
||
Pure negative code; my favorite kind of patch.
Assignee: nobody → stuart.morgan
Status: NEW → ASSIGNED
Attachment #275545 -
Flags: superreview?(mark)
|
||
Comment 2•17 years ago
|
||
Comment on attachment 275545 [details] [diff] [review]
cleanup
Targeted at 1.6, correct?
Attachment #275545 -
Flags: superreview?(mark) → superreview+
|
|
Assignee | |
Comment 3•17 years ago
|
||
Yep, 1.6 and trunk.
Whiteboard: [good first bug]
Target Milestone: --- → Camino1.6
|
|
Assignee | |
Comment 4•17 years ago
|
||
Landed on trunk and MOZILLA_1_8_BRANCH.
You need to log in
before you can comment on or make changes to this bug.
Description
•