389175 - Build failure with --enable-glitz

Status: RESOLVED WONTFIX

(Firefox Build System :: General, defect)

Description

[Tomas Carnecky]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.1.5) Gecko/20070720 Firefox/2.0.0.5
Build Identifier: CVS trunk

Looks like missing/incorrect headers, here's the last few lines of 'make -f client.mk build': 


gmake[7]: Entering directory `/home/tomc/devel/mozilla/gfx/cairo/glitz/src/glx'
glitz_glx_drawable.c
gcc -o glitz_glx_drawable.o -c  -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_COM_OBSOLETE -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET  -DZLIB_INTERNAL -DOSTYPE=\"Linux2.6\" -DOSARCH=Linux -I. -I./.. -I../../../../../dist/include/glitz -I../../../../../dist/include   -I../../../../../dist/include/glitzglx -I../../../../../dist/include/nspr  -DMOZ_PNG_READ -DPNG_NO_MMX_CODE -DMOZ_PNG_WRITE  -I../../../../../dist/sdk/include    -fPIC  -Wall -W -Wno-unused -Wpointer-arith -Wcast-align -Wno-long-long -pedantic -pthread -pipe  -DNDEBUG -DTRIMMED -O   -include ../../../../../mozilla-config.h -DMOZILLA_CLIENT -Wp,-MD,.deps/glitz_glx_drawable.pp glitz_glx_drawable.c
In file included from glitz_glxint.h:30,
                 from glitz_glx_drawable.c:30:
./../glitzint.h:29:28: error: cairo-platform.h: No such file or directory
glitz_glx_format.c
glitz_glx_drawable.c: In function 'glitz_glx_create_drawable_for_window':
glitz_glx_drawable.c:156: warning: comparison between signed and unsigned
glitz_glx_drawable.c: In function 'glitz_glx_create_pbuffer_drawable':
glitz_glx_drawable.c:191: warning: comparison between signed and unsigned
gcc -o glitz_glx_format.o -c  -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_COM_OBSOLETE -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET  -DZLIB_INTERNAL -DOSTYPE=\"Linux2.6\" -DOSARCH=Linux -I. -I./.. -I../../../../../dist/include/glitz -I../../../../../dist/include   -I../../../../../dist/include/glitzglx -I../../../../../dist/include/nspr  -DMOZ_PNG_READ -DPNG_NO_MMX_CODE -DMOZ_PNG_WRITE  -I../../../../../dist/sdk/include    -fPIC  -Wall -W -Wno-unused -Wpointer-arith -Wcast-align -Wno-long-long -pedantic -pthread -pipe  -DNDEBUG -DTRIMMED -O   -include ../../../../../mozilla-config.h -DMOZILLA_CLIENT -Wp,-MD,.deps/glitz_glx_format.pp glitz_glx_format.c
gmake[7]: *** [glitz_glx_drawable.o] Error 1
gmake[7]: *** Waiting for unfinished jobs....
In file included from glitz_glxint.h:30,
                 from glitz_glx_format.c:30:
./../glitzint.h:29:28: error: cairo-platform.h: No such file or directory
glitz_glx_format.c: In function 'glitz_glx_find_drawable_format_for_visual':
glitz_glx_format.c:420: warning: comparison between signed and unsigned
gmake[7]: *** [glitz_glx_format.o] Error 1
gmake[7]: Leaving directory `/home/tomc/devel/mozilla/gfx/cairo/glitz/src/glx'
gmake[6]: *** [libs] Error 2
gmake[6]: Leaving directory `/home/tomc/devel/mozilla/gfx/cairo/glitz/src'
gmake[5]: *** [libs] Error 2
gmake[5]: Leaving directory `/home/tomc/devel/mozilla/gfx/cairo'
gmake[4]: *** [libs] Error 2
gmake[4]: Leaving directory `/home/tomc/devel/mozilla/gfx'
gmake[3]: *** [libs_tier_gecko] Error 2
gmake[3]: Leaving directory `/home/tomc/devel/mozilla'
gmake[2]: *** [tier_gecko] Error 2
gmake[2]: Leaving directory `/home/tomc/devel/mozilla'
make[1]: *** [default] Error 2
make[1]: Leaving directory `/home/tomc/devel/mozilla'
make: *** [build] Error 2


Reproducible: Always

Comment 2

[Tomas Carnecky]

Are you sure? I tried that patch and it didn't work. And besides, my build fails with a missing header, the other bug is about wrong shared libraries paths.

Comment 3

[Boying Lu]

Attachment: patch

Comment 4

[Tomas Carnecky]

(In reply to comment #3)
> Created an attachment (id=273707) [details]
> patch
> 

This fixes the above mentioned build error, but later on I get another one:

rm -f libxul.so
c++  -fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-long-long -pedantic -fshort-wchar -pthread -pipe  -DNDEBUG -DTRIMMED -O -fPIC -shared -Wl,-z,defs -Wl,-h,libxul.so -o libxul.so  nsStaticXULComponents.o nsUnicharUtils.o nsCompressedCharMap.o nsBidiUtils.o nsRDFResource.o    -lpthread    -Wl,--whole-archive ../../embedding/browser/gtk/src/libgtkembedmoz.a ../../toolkit/xre/libxulapp_s.a  ../../staticlib/components/libxpconnect.a ../../staticlib/components/libnecko.a ../../staticlib/components/libuconv.a ../../staticlib/components/libi18n.a ../../staticlib/components/libchardet.a ../../staticlib/components/libjar50.a ../../staticlib/components/libpref.a ../../staticlib/components/libcaps.a ../../staticlib/components/libhtmlpars.a ../../staticlib/components/libimglib2.a ../../staticlib/components/libgklayout.a ../../staticlib/components/libxmlextras.a ../../staticlib/components/libdocshell.a ../../staticlib/components/libembedcomponents.a ../../staticlib/components/libwebbrwsr.a ../../staticlib/components/libnsappshell.a ../../staticlib/components/libtxmgr.a ../../staticlib/components/libchrome.a ../../staticlib/components/libcommandlines.a ../../staticlib/components/libtoolkitcomps.a ../../staticlib/components/libpipboot.a ../../staticlib/components/libpipnss.a ../../staticlib/components/libgkplugin.a ../../staticlib/components/libmozfind.a ../../staticlib/components/libappcomps.a ../../staticlib/components/libxpinstall.a ../../staticlib/components/libjsd.a ../../staticlib/components/libautoconfig.a ../../staticlib/components/libauth.a ../../staticlib/components/libcookie.a ../../staticlib/components/libpermissions.a ../../staticlib/components/libuniversalchardet.a ../../staticlib/components/libcomposer.a ../../staticlib/components/librdf.a ../../staticlib/components/libwindowds.a ../../staticlib/components/libintlapp.a ../../staticlib/components/libfileview.a ../../staticlib/components/libstoragecomps.a ../../staticlib/components/libplaces.a ../../staticlib/components/libtkautocomplete.a ../../staticlib/components/libsatchel.a ../../staticlib/components/libpippki.a ../../staticlib/components/libucvmath.a ../../staticlib/components/libwidget_gtk2.a ../../staticlib/components/libsystem-pref.a ../../staticlib/components/libgkgfxthebes.a ../../staticlib/components/liboji.a ../../staticlib/components/libaccessibility.a ../../staticlib/components/libremoteservice.a ../../staticlib/components/libspellchecker.a ../../staticlib/libxpcom_core.a ../../staticlib/libucvutil_s.a ../../staticlib/libgkgfx.a ../../staticlib/libgfxshared_s.a ../../staticlib/libmozreg_s.a ../../staticlib/libmorkreader_s.a ../../staticlib/libgtkxtbin.a ../../staticlib/libgfxpsshar.a ../../staticlib/libthebes.a ../../staticlib/libjsj.a  -Wl,--no-whole-archive  -lsqlite3 -Wl,-rpath-link,../../dist/bin -L../../dist/bin -L../../dist/lib -L../../jpeg -lmozjpeg -L../../modules/libimg/png -lmozpng -L../../dist/bin -lmozlcms -L../../dist/bin -lmozjs -L../../dist/bin -L../../dist/lib -lcrmf -lsmime3 -lssl3 -lnss3 -lsoftokn3  -L../../modules/zlib/src -lmozz -lpangoxft-1.0 -lpangoft2-1.0 -lpango-1.0 -lgobject-2.0 -lgmodule-2.0 -ldl -lglib-2.0   -L../../gfx/cairo/cairo/src -lmozcairo -L../../gfx/cairo/libpixman/src -lmozlibpixman   -L/usr/lib64 -lXrender -lfreetype -lfontconfig -L../../gfx/cairo/glitz/src -lmozglitz -L../../gfx/cairo/glitz/src/glx -lmozglitzglx -lGL -L../../dist/lib -lplds4 -lplc4 -lnspr4 -lpthread -ldl -L/usr/lib64 -lX11  -lXft -lXrender -lfontconfig -lfreetype -lz -lX11   -lgtk-x11-2.0 -latk-1.0 -lgdk-x11-2.0 -lgdk_pixbuf-2.0 -lm -lpangocairo-1.0 -lpango-1.0 -lcairo -lgmodule-2.0 -ldl -lgobject-2.0 -lglib-2.0   -lXt -lgthread-2.0 -lfreetype -lz -ldl -lm     
/usr/lib/gcc/x86_64-pc-linux-gnu/4.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: ../../staticlib/components/libwidget_gtk2.a(nsWindow.o): relocation R_X86_64_PC32 against `glitz_glx_find_window_format' can not be used when making a shared object; recompile with -fPIC
/usr/lib/gcc/x86_64-pc-linux-gnu/4.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: final link failed: Bad value
collect2: ld returned 1 exit status
gmake[4]: *** [libxul.so] Error 1
gmake[4]: Leaving directory `/home/tomc/devel/mozilla/toolkit/library'
gmake[3]: *** [libs_tier_toolkit] Error 2
gmake[3]: Leaving directory `/home/tomc/devel/mozilla'
gmake[2]: *** [tier_toolkit] Error 2
gmake[2]: Leaving directory `/home/tomc/devel/mozilla'
make[1]: *** [default] Error 2
make[1]: Leaving directory `/home/tomc/devel/mozilla'
make: *** [build] Error 2

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 273707 [details] [diff] [review]
patch

Not fixing glitz, will be removing it entirely