389183 - Download Manager window remains empty

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007072211 Minefield/3.0a7pre ID:2007072211

repro:

open FF
start a download
open DM

result:
The download is not displayed at all

Error: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [mozIStorageConnection.createStatement]
Source file: chrome://mozapps/content/downloads/downloads.js
Line: 443

regression from Bug 385875

Comment 1

[Peter van der Woude [:Peter6]]

after you have downloaded something, which process you can follow with win explorer it gives the following error when you close the useless DM window:
Error: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIObserverService.removeObserver]
Source file: chrome://mozapps/content/downloads/downloads.js
Line: 515

Comment 2

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

d'oh

This should do the trick

Comment 3

[Shawn Wilsher :sdwilsh]

(In reply to comment #1)
> after you have downloaded something, which process you can follow with win
> explorer it gives the following error when you close the useless DM window:
> Error: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE)
> [nsIObserverService.removeObserver]
> Source file: chrome://mozapps/content/downloads/downloads.js
> Line: 515
expected since it never adds those because it fails before then

Comment 4

[Asaf Romano (gone)]

Comment on attachment 273323 [details] [diff] [review]
v1.0

r=mano

Comment 5

[Shawn Wilsher :sdwilsh]

Sorry about that...

Checking in toolkit/mozapps/downloads/content/downloads.js;
new revision: 1.68; previous revision: 1.67

Comment 6

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007072215 Minefield/3.0a7pre ID:2007072215

Thanks Shawn
->VERIFIED