Closed Bug 389259 Opened 13 years ago Closed 13 years ago

Scroll thumbs non-functional beginning in 2007072300 branch build

Categories

(Camino Graveyard :: Page Layout, defect)

1.8 Branch
PowerPC
macOS
defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: alqahira, Assigned: stuart.morgan+bugzilla)

References

Details

(Keywords: fixed1.8.0.13, fixed1.8.1.8, Whiteboard: [camino-1.5.1])

Attachments

(1 file)

fix
1.79 KB, patch
mikepinkerton
: review+
mikepinkerton
: superreview+
Details | Diff | Splinter Review
Beginning in today's branch nightly, scroll thumbs no longer work, both in <select multiple/size> widgets or on the page itself.  These worked yesterday.  (I have no idea if the problem also exists on trunk or not, since I can't test there; I also don't have time at the moment to check the fox, so filing in Camino for now).

Regression range: http://tinyurl.com/ytg4og

That looks like roc and friends in bug 388583.

This is probably a blocker for our 1.5.1 release.
Flags: camino1.5.1?
Luckily for the fox, I don't see this regression in Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.6) Gecko/2007072301 Firefox/2.0.0.6.
That's because it was apparently the change to fix Firefox without making the corresponding change to the cocoa widget source that broke us.
Attached patch fixSplinter Review
This is the cocoa widget change that should have been made as part of the changes related to bug 388583.
Assignee: nobody → stuart.morgan
Status: NEW → ASSIGNED
Attachment #273417 - Flags: superreview?(roc)
Attachment #273417 - Flags: review?
Attachment #273417 - Flags: review? → review?(mikepinkerton)
Requesting blocking. This completely broke basic scrolling functionality on all web pages in Camino, both the pages themselves and all scrollable elements within the page, for Camino on a stable branch.
Flags: blocking1.8.1.7?
Flags: blocking1.8.1.6?
Keywords: qawanted
Comment on attachment 273417 [details] [diff] [review]
fix

sr=pink

let's get this on the branch ASAP.
Attachment #273417 - Flags: superreview?(roc) → superreview+
Comment on attachment 273417 [details] [diff] [review]
fix

i am the pumpkin king!
Attachment #273417 - Flags: review?(mikepinkerton) → review+
This patch is in widget/src/cocoa on the 1.8 branch, which limits it to Camino-only.
Sorry about that, I forgot we had Cocoa users on the branch :-(
Attachment #273417 - Flags: approval1.8.1.7+
Landed on MOZILLA_1_8_BRANCH.
nsNativeScrollbar.mm, version 1.17.2.5
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: camino1.5.1?
Flags: camino1.5.1+
Flags: blocking1.8.1.7?
Flags: blocking1.8.1.6?
Keywords: regressionfixed1.8.1.7
Resolution: --- → FIXED
mento will massage whatever's needed to get this in 1.5.1's Gecko and add [camino-1.5.1] to the whiteboard when it's done.
Elsewhere I believe you guys said you wanted to ship from a Firefox/Gecko release tag. We're not tagging the mozilla1.8 branch any time soon (1.8.1.7 is many weeks away); 1.8.1.6 will be shipped from GECKO181_20070712_RELBRANCH and something along there is what will get tagged as the FIREFOX_2_0_0_6_RELEASE
Are there any more Camino releases from the 1.8.0 branch? If so we may want to take this one in 1.8.0.13 since we're taking bug 388583
Flags: blocking1.8.0.13?
Dan, we're going to have one more release off the 1.8.0 branch. So yeah, we should take this. Thanks for looking out for us. :)
Attachment #273417 - Flags: approval1.8.0.13?
This needs to block 1.0.6, then, too.
Flags: camino1.0.6+
Flags: blocking1.8.0.13? → blocking1.8.0.13+
Comment on attachment 273417 [details] [diff] [review]
fix

approved for 1.8.0.13, a=dveditz
Attachment #273417 - Flags: approval1.8.0.13? → approval1.8.0.13+
Keywords: checkin-needed
Whiteboard: [needs checkin 1.8.0 branch]
fix checked into 1.8.0.13
Keywords: fixed1.8.0.13
Thanks for landing this, dveditz!
Keywords: checkin-needed
Whiteboard: [needs checkin 1.8.0 branch]
CAMINO_1_5_1_RELEASE uses the Gecko of FIREFOX_2_0_0_6_RELEASE, with the exception of this file, which comes from MOZILLA_1_8_BRANCH.

Also, camino/ and client.mk were tagged based on our current CAMINO_1_5_1_BRANCH, with the exception of some versioned files, CAMINO_1_5_1_MINIBRANCH.

We'll probably do 1.0.6 off 1.8.0.13 tomorrow.  dveditz, is there a branch or tag corresponding to 1.8.0.13?  I don't want to our 1.0.6 release to claim to be 1.8.0.13 if it's not 1.8.0.13-final.
Whiteboard: [camino-1.5.1]
Nick created tags GECKO180_20070809_RELBRANCH, THUNDERBIRD_1_5_0_13_RC1 and THUNDERBIRD_1_5_0_13_RELEASE.

If QA doesn't find any problems this will be the 1.8.0.13 release, if we have a regression or two we'll create a _RC2 and move the _RELEASE tag.

The odds: grepping the tags from client.mk I see 
 61 _RC1
 38 _RC2
 17 _RC3
  9 _RC4
  7 _RC5
  3 _RC6
  1 _RC7

And a warning: This release contains several back-ports of security fixes from the trunk and Firefox 2.0.0.5 that have not yet been tested on the 1.8.0 branch and may be difficult to test in a non-browser product like Thunderbird. What passes muster for Thunderbird (default JavaScript off, no plugins, no SVG, etc) may not be good enough for a browser like Camino; you'll want to test this one reasonably well and there may be some subsequent regression fixes we'll need before considering it "final 1.8.0.13".
Thanks, Dan.  I'll spin rc1 for us tomorrow.  We'll subject it to some testing and make noise if anything seems out of place in Gecko, and I'll track you guys if you need further RCs.
You need to log in before you can comment on or make changes to this bug.