389287 - remove shim URL handler

Status: RESOLVED FIXED

(Firefox :: Installer, defect)

Description

[Daniel Veditz [:dveditz]]

rstrong said the following in bug 384384 comment 56:

Created [attachment 273430 [details] [diff]]
Remove the handler added by the MS shim

After reading the following
http://msinfluentials.com/blogs/jesper/archive/2007/07/10/blocking-the-firefox-gt-ie-0-day.aspx

I realized we also need to remove the handler added by the MS shim.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch (already reviewed by sspitzer)

Comment 2

[Robert Strong (they/them - no direct email)]

Checked in to trunk (comment is incorrect)

Checking in mozilla/browser/installer/windows/nsis/shared.nsh;
/cvsroot/mozilla/browser/installer/windows/nsis/shared.nsh,v  <--  shared.nsh
new revision: 1.12; previous revision: 1.11
done

Comment 3

[Robert Strong (they/them - no direct email)]

This affects Vista users that have installed a Firefox version where the Vista compatibility shim is applied which should be all versions prior to 2.0.0.2.

Comment 4

[Robert Strong (they/them - no direct email)]

Checked in to MOZILLA_1_8_BRANCH

Checking in mozilla/browser/installer/windows/nsis/shared.nsh;
/cvsroot/mozilla/browser/installer/windows/nsis/shared.nsh,v  <--  shared.nsh
new revision: 1.3.2.9; previous revision: 1.3.2.8
done

Comment 5

[Daniel Veditz [:dveditz]]

This has been fixed for 1.8.1.7 (the 1.8 branch) but not yet 1.8.1.6 (GECKO181_20070712_RELBRANCH).

Comment 6

[Daniel Veditz [:dveditz]]

Comment on attachment 273436 [details] [diff] [review]
patch (already reviewed by sspitzer)

a=dveditz for 1.8.1.7

Comment 7

[Robert Strong (they/them - no direct email)]

Checked in to GECKO181_20070712_RELBRANCH

Checking in mozilla/browser/installer/windows/nsis/shared.nsh;
/cvsroot/mozilla/browser/installer/windows/nsis/shared.nsh,v  <--  shared.nsh
new revision: 1.3.2.8.2.1; previous revision: 1.3.2.8
done

Comment 8

[Robert Strong (they/them - no direct email)]

To verify

install a build where the shim is applied (e.g. 2.0.0.0) and run it.
verify that Firefox.URL exists under HKEY_CLASSES_ROOT.
install a latest nightly with the installer.
verify that Firefox.URL does not exist under HKEY_CLASSES_ROOT.

and

install a build where the shim is applied (e.g. 2.0.0.0) and run it.
install a nightly build prior to this patch landing (e.g. 20070722)
verify that Firefox.URL exists under HKEY_CLASSES_ROOT.
update via software update.
verify that Firefox.URL does not exist under HKEY_CLASSES_ROOT.

Comment 9

[Carsten Book [:Tomcat]]

verified fixed using the steps to reproduce from comment #8 

Was going from Firefox 2.0.0.0 to latest Trunk  - Firefox.URL was removed from HKEY_CLASSES_ROOT

Also PASS on the 2nd test - installed Firefox 2.0 - installed Firefox 1.8 Nighly (2007062904) and then used the Sofware Update to Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.6pre) Gecko/2007072403 BonEcho/2.0.0.6pre

Firefox.URL was also removed from HKEY_CLASSES_ROOT - adding verified 1.8.1.6 keyword 

Comment 10

[Carsten Book [:Tomcat]]

verified fixed 1.8.1.7 using :
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1) Gecko/2006101023 Firefox/2.0 to Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.7pre) Gecko/2007082904 BonEcho/2.0.0.7pre via Installer and AUS.

In both cases Firefox.URL was removed from HKEY_CLASSES_ROOT 

Adding verified keyword