389303 - Use one ellipsis character (…) instead of three dots (...) in titles

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, enhancement)

Description

[Pete Riley]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.5) Gecko/20070713 Firefox/2.0.0.5
Build Identifier: 

We could see an additional two characters of every event/task title if Lightning/Sunbird used one ellipsis character (…) instead of three dots (...) when there isn't enough room for the whole title.  This would apply to all the views, the Today Pane, etc.

(Thanks to mvl for the idea (in a different bug report).)

Reproducible: Didn't try

Comment 1

[Dão Gottwald [:dao]]

You're using <label>, right?

Comment 2

[Pete Riley]

I actually don't know anything about XUL or <label> but maybe one of the calendar developers will answer your question.

It would be great if the bug that you submitted (bug 390282) would be implemented, then the calendar developers might not have to do anything.  :)

Comment 3

[Pete Riley]

Dão has fixed bug 390282 in "Core - XP Toolkit/Widgets: XUL".

However, I don't think that this will be a completely automatic change for Lightning/Sunbird.  For example, Sunbird sometimes uses the ellipsis character in the code, but other times it uses three dots, as mentioned in Firefox bug 373623 comment 5.

Comment 4

[Simon Paquet [:sipaq]]

Attachment: Patch for all files (except installer and updater)

Comment 5

[Simon Paquet [:sipaq]]

Attachment: 2nd try

Comment 6

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Attachment: [checked in] 3rd try

Comment 7

[Daniel Boelzle [:dbo]]

Comment on attachment 276005 [details] [diff] [review]
[checked in] 3rd try

r=dbo

Comment 8

[Martin Schröder [:mschroeder]]

Comment on attachment 276005 [details] [diff] [review]
[checked in] 3rd try

This patch has already been checked in on 2007-08-10. Can this bug be closed?

Comment 9

[Simon Paquet [:sipaq]]

As far as I know this bug is only completely fixed on the trunk, because the two relevant patches from bug 390282 only landed there. It is not fully fixed on the branch and will only be fixed, if both of my approval requests for branch inclusion in that bug get plussed.

Therefore this bug should remain open until either the two patches from bug 390282 land on the branch or we move to the trunk.

Comment 10

[Simon Paquet [:sipaq]]

My approval requests in bug 390282 were granted and the necessary checkins were made. Can someone please test, whether this fully fixes this bug in a current tinderbox build or tomorrow's nightly?

Comment 11

[Pete Riley]

I don't see the ellipses at the end of event titles in the month view.  I'm using Lightning 20070901 03 and TB 2.0.0.6 (official release).  Do I need to use a TB nightly?

Also, three dots are still being used in other places:

1) When I right click on the toolbar in calendar mode, I see "Customize..." instead of "Customize…".

2) the same thing in the event dialog with "View > Toolbars > Customize..."

3) in the today pane, but I realize that this is still being designed/implemented.

Comment 12

[Stefan Sitter [:ssitter]]

(In reply to comment #11)
Yes, you need either Sunbird or Thunderbird build 20070830 or newer.

Comment 13

[Simon Paquet [:sipaq]]

Pete,
this is due to the underlying Thunderbird code. Thunderbird does not seem to use the ellipsis character at all. It would be great if you file a Thunderbird bug for that, but since string changes will probably not be made in TB2, this will have to wait until TB3 comes out.

Comment 14

[Pete Riley]

I downloaded and installed a TB nightly from:
http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/latest-mozilla1.8/thunderbird-2.0.0.7pre.en-US.win32.installer.exe

The ellipsis character seems to work correctly at the end of event titles and in the today pane!  Since the TB version is 2.0.0.7pre, maybe it will be included in the next TB 2 official release and I don't have to create a TB bug for this?

However, I still see three dots in cases (1) and (2) that I mentioned in comment 11.  This makes me wonder if there are still other places in the Lightning/Sunbird code that are still using three dots instead of the ellipsis character.

Comment 15

[Simon Paquet [:sipaq]]

Pete, please read my comment 13 carefully. Those strings come from Thunderbird and there is nothing we can do about it. I filed bug 394641 about this. We'll see how the TB devs react. 

Since the bug described in comment 0 is now fixed, I'm marking this as FIXED. Please file new bugs, if you come across strings that do not use the ellipsis character *AND* are derived from Calendar code. Your items (1) and (2) are *NOT* calendar bugs.

Comment 16

[Stefan Sitter [:ssitter]]

There is at least one string in calendar that still uses three dots. 
The patch in Bug 393608 will fix this string too.

Comment 17

[Pete Riley]

Simon, I misunderstood your comment 13.  I thought that you were talking about everything in my comment 11.  Now I realize that you were only talking about points (1) and (2).  Thanks for explaining it to me.  Personally I don't really care if we have to wait until TB 3 for those things.

IMO the important thing is to have the ellipsis in event titles and in the today pane, and it seems that you have fixed this (after people upgrade to TB 2.0.0.7), so thanks!!!

Comment 18

[Martin Schröder [:mschroeder]]

VERIFIED with Lightning 0.7pre (20070924) and Sunbird 0.7pre (20070924).