389320 - lots of worrisome warnings building sqlite3.c on Windows

Status: RESOLVED WONTFIX

(NSS :: Libraries, defect, P3)

Description

[Nelson Bolyard (seldom reads bugmail)]

Attachment: warnings from MSVC

I pulled and built a fresh NSS trunk tree today on Windows, and got a huge
number of warnings for sqlite3.c.  See the full list, attached.

Many of them have to do with integral size mismatches, especially implicit 
conversions from __int64 to smaller sizes.  

I think these all need to be reviewed.  Casts should probably be applied
to ones that are OK, to shut them up, and ones that aren't OK should be fixed.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Unsetting target milestone in unresolved bugs whose targets have passed.

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Since NSS's copy of this code is downstream from its source, 
we could send a report of these warnings upstream.  
But we're not using the latest sqlite3 code, AFAIK, and we probably 
should update first.

Comment 3

[Takanori MATSUURA]

(In reply to Nelson Bolyard (seldom reads bugmail) from comment #0)
Can you still see those warnings?

Comment 4

[Chris Peterson [:cpeterson]]

We don't care about minor warnings in third-party code. The C4244 warnings were suppressed by bug 857863.