Closed Bug 389320 Opened 13 years ago Closed 4 years ago

lots of worrisome warnings building sqlite3.c on Windows

Categories

(NSS :: Libraries, defect, P3)

x86
Windows XP
defect

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: nelson, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [build_warning])

Attachments

(1 file)

Attached file warnings from MSVC
I pulled and built a fresh NSS trunk tree today on Windows, and got a huge
number of warnings for sqlite3.c.  See the full list, attached.

Many of them have to do with integral size mismatches, especially implicit 
conversions from __int64 to smaller sizes.  

I think these all need to be reviewed.  Casts should probably be applied
to ones that are OK, to shut them up, and ones that aren't OK should be fixed.
Target Milestone: --- → 3.12
Version: 3.12 → trunk
Unsetting target milestone in unresolved bugs whose targets have passed.
Target Milestone: 3.12 → ---
Blocks: 326315
Since NSS's copy of this code is downstream from its source, 
we could send a report of these warnings upstream.  
But we're not using the latest sqlite3 code, AFAIK, and we probably 
should update first.
Priority: -- → P3
Whiteboard: [build_warning]
(In reply to Nelson Bolyard (seldom reads bugmail) from comment #0)
Can you still see those warnings?
We don't care about minor warnings in third-party code. The C4244 warnings were suppressed by bug 857863.
Status: NEW → RESOLVED
Closed: 4 years ago
Depends on: 857863
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.