389378 - www.zdjecia.pl - page menu is totally broken

Status: RESOLVED WORKSFORME

(Core :: Layout: Floats, defect)

Description

[Quan Lin]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007072304 Minefield/3.0a7pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007072304 Minefield/3.0a7pre

Page menu is totally broken.

Reproducible: Always

Steps to Reproduce:
1.Open browser
2.Go to page www.zdjecia.pl


Actual Results:  
Page menu is totally broken. See attached screenshots from device and desktop.


Expected Results:  
Page menu under top image looks ok and is in one line.

Comment 1

[Steve England [:stevee]]

What attached screenshots? :)

Comment 2

[Arie Paap [:wildmyron]]

Attachment: Testcase

The bug occurs because a line break occurs after the space in one of the menu entries. I'm guessing this is caused by the recent line breaking fixes - bug 255990 ?

Haven't looked for duplicates but I didn't see anything in the dependencies of bug 255990.

I'll leave it to some one else to work out if it's expected that there be a line break after the space in this case.

Comment 3

[-fullmetaljacket-]

this regressed even before bug 255990 was fixed

btw, it was marked blocking bug 300030 ;)

Comment 4

[Mats Palmgren (inactive)]

Attachment: Testcase #2

Both testcases triggers this assertion in a debug build:
###!!! ASSERTION: If we asked for force-fit, it should have been placed: 'placed || !forceFit', file nsBlockReflowState.cpp, line 548

Comment 5

[Mats Palmgren (inactive)]

Testcase #1 and #2 is WFM due to bug 387201 and the assertion is gone too.
I think there is still a bug here though.

Comment 6

[Mats Palmgren (inactive)]

Attachment: Testcase #3

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Is the new testcase a regression?

Comment 8

[Mats Palmgren (inactive)]

Attachment: Testcase #4 (same as #3, but without -moz-float-edge:margin-box)

(In reply to comment #7)
> Is the new testcase a regression?

The reflow branch landing changed the layout.  I think there are
two issues here.  The first is that we layout two floats on top of
each other in Testcase #3.  I think the layout should be more like #4,
but I'm not really sure what -moz-float-edge:margin-box really means...

The second issue is that we only make the outer float wide enough
to fit the widest descendant.  Firefox 2 makes the outer float wide
enough to fit all floats on one line (given a wide enough window).
I think Firefox 2 better implements shrink-to-fit according to
CSS 2.1 10.3.5: http://www.w3.org/TR/CSS21/visudet.html#float-width

FWIW, Fx 2 and IE7 have the same layout; Opera9, Webkit and Fx trunk
have the same layout (for issue 2 that is).

Comment 9

[u554753]

Works for me with the following specifications: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0

Though it may be possible that the website went through a redesign or two since the filing of this bug. If you can still reproduce the issue, please reopen and provide current information. Thanks.