FillContentHandlerProperties incorrectly returns NS_ERROR_FAILURE

RESOLVED FIXED in mozilla1.9alpha8

Status

Core Graveyard
File Handling
RESOLVED FIXED
11 years ago
2 years ago

People

(Reporter: dmose, Assigned: dmose)

Tracking

unspecified
mozilla1.9alpha8

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
Created attachment 273640 [details] [diff] [review]
patch, v1

When a preferred application handler is not specified in the RDF file.  This semantic got broken in the refactoring.  See the URL attached to this bug around line 845 and onwards for the original codeflow.
Flags: blocking1.9?
(Assignee)

Comment 1

11 years ago
Comment on attachment 273640 [details] [diff] [review]
patch, v1

Requesting review, as I can't see any way to test this.  The case that's being fixed is the protocol handling case, and that code is not accessible from JS.  The MIME code eats the error, and I have yet to figure out a way to tell the difference between the error and success cases from JS, though one may exist.
Attachment #273640 - Flags: superreview?(cbiesinger)
Attachment #273640 - Flags: review?(cbiesinger)
(Assignee)

Comment 2

11 years ago
Another mitigating factor of the lack of test here is that this code should be killed before too long as it all ends up in nsHandlerService.js.
Comment on attachment 273640 [details] [diff] [review]
patch, v1

r+sr=bzbarsky
Attachment #273640 - Flags: superreview?(cbiesinger)
Attachment #273640 - Flags: superreview+
Attachment #273640 - Flags: review?(cbiesinger)
Attachment #273640 - Flags: review+
(Assignee)

Comment 4

11 years ago
Fixed:

Checking in nsExternalHelperAppService.cpp;
/cvsroot/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp,v  <--  nsExternalHelperAppService.cpp
new revision: 1.325; previous revision: 1.324
done
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.