389446 - FillContentHandlerProperties incorrectly returns NS_ERROR_FAILURE

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: patch, v1

When a preferred application handler is not specified in the RDF file.  This semantic got broken in the refactoring.  See the URL attached to this bug around line 845 and onwards for the original codeflow.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 273640 [details] [diff] [review]
patch, v1

Requesting review, as I can't see any way to test this.  The case that's being fixed is the protocol handling case, and that code is not accessible from JS.  The MIME code eats the error, and I have yet to figure out a way to tell the difference between the error and success cases from JS, though one may exist.

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Another mitigating factor of the lack of test here is that this code should be killed before too long as it all ends up in nsHandlerService.js.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 273640 [details] [diff] [review]
patch, v1

r+sr=bzbarsky

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Fixed:

Checking in nsExternalHelperAppService.cpp;
/cvsroot/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp,v  <--  nsExternalHelperAppService.cpp
new revision: 1.325; previous revision: 1.324
done