389464 - <font size="-1"> is not respected within <pre> blocks

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Adam Guthrie]

Attachment: testcase

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007072405 Minefield/3.0a7pre

Steps to reproduce:
1. Load testcase.

Actual results:
The text inside the <pre><font></font></pre> block is larger sized.

Expected results:
All the text is the same size.

I first noticed this on the bonsai diffs page: http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/embedding/components/find/src&command=DIFF_FRAMESET&file=nsFind.cpp&rev1=1.46&rev2=1.47&root=/cvsroot.

Regressed between 20070723_2058 and 20070723_2058, making this a regression from bug 383979.

Comment 1

[Adam Guthrie]

Err, obvious copy/paste error above should read: "regressed between 20070723_2058 and 20070723_2117".

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Yeah, I'm not surprised that generic font change broke something.  Maybe it's time to stop fixing this mess and just fix bug 380915.

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: possible patch

This compiles, but I haven't tested it yet.

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: patch

So I think this should work correctly.  It sets mFlags during computation and only overwrites it when we should be overwriting it.  But we do need to overwrite it each cycle during SetGenericFont (which matches the old behavior, since then mFlags wasn't set at all during the loop).

Then it uses the newly-correct mFlags to get the right base font size.

I removed the aDefaultFont parameter since the only other use was if (!aIsGeneric), in which case it was guaranteed to be defaultVariableFont.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 273789 [details] [diff] [review]
patch

Looks reasonable.

Comment 6

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Checked in to trunk (with the additional SetFont call in SetGenericFont modified the same way, since the patch above was in my queue above bug 216456).

Comment 7

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: also mark mochitests passing

Comment 8

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

This fixed bug 385699, but bugzilla won't let me add the dependency.

Comment 9

[Adam Guthrie]

Hrm... this didn't fix the issue on the Bonsai diff. pages for some reason.