User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:220.127.116.11) Gecko/20070713 Firefox/18.104.22.168 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:22.214.171.124) Gecko/20070713 Firefox/126.96.36.199 I like the new enhancement with favicons on location bar autocomplete results. Thus on back/forward menus would be nice too. Reproducible: Always
It would be great to get this into the new integrated menu being worked on over in bug 386228
Created attachment 300446 [details] Screenshot My plan is to add the favicons to all options _except_ the currently selected one, because a favicon on that to would make it harder to notice what position you are already on despite the bold effect. The inconsistency between the favicons and the bullet makes it more noticeable at a glance which position you are in, while still providing the usability benefit of favicons.
Created attachment 300447 [details] [diff] [review] Patch
Comment on attachment 300447 [details] [diff] [review] Patch This kinda conflicts with bug 414366 a little bit, but I suppose we could do both, and have the arrow replace the favicon on hover, or something.
(In reply to comment #5) > (From update of attachment 300447 [details] [diff] [review]) > and have the arrow replace the favicon on hover, or something. Seems like a good idea.
> and have the arrow replace the favicon on hover, or something. yeah, I think this is the best way to integrate both patches. Note that the bullet is the correct choice, IE7 is incorrectly using the check box (implying that you can navigate to more than one page at a time).
Just filed Bug 415018 to add a history item on the bottom of this menu.
Do we want to land these bugs (this one and bug 414366) together or separately?
separately Note that Michael's patch works for Linux only, which I'm going to fix in bug 414366.
Checking in browser/base/content/browser.js; /cvsroot/mozilla/browser/base/content/browser.js,v <-- browser.js new revision: 1.960; previous revision: 1.959 done
Created attachment 301856 [details] screenshot 20080207_0142_firefox-3.0b4pre.en-US.win32.zip no favicon.
(In reply to comment #12) > 20080207_0142_firefox-3.0b4pre.en-US.win32.zip > > no favicon. See comment #10.
Verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:188.8.131.52) Gecko/2008120122 Firefox/3.0.5