The default bug view has changed. See this FAQ.

Add favicons on back/forward menus

VERIFIED FIXED in Firefox 3 beta4

Status

()

Firefox
Bookmarks & History
--
enhancement
VERIFIED FIXED
10 years ago
8 years ago

People

(Reporter: Emil Ivanov, Assigned: Michael Ventnor)

Tracking

Trunk
Firefox 3 beta4
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

10 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.5) Gecko/20070713 Firefox/2.0.0.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.5) Gecko/20070713 Firefox/2.0.0.5

I like the new enhancement with favicons on location bar autocomplete results.
Thus on back/forward menus would be nice too.

Reproducible: Always

Comment 1

10 years ago
-> NEW
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Reporter)

Updated

10 years ago
Component: Toolbars → Places
Version: unspecified → Trunk
QA Contact: toolbars → places
It would be great to get this into the new integrated menu being worked on over in bug 386228 

Updated

9 years ago
OS: Windows XP → All
Hardware: PC → All
(Assignee)

Comment 3

9 years ago
Created attachment 300446 [details]
Screenshot

My plan is to add the favicons to all options _except_ the currently selected one, because a favicon on that to would make it harder to notice what position you are already on despite the bold effect. The inconsistency between the favicons and the bullet makes it more noticeable at a glance which position you are in, while still providing the usability benefit of favicons.
Attachment #300446 - Flags: ui-review?(beltzner)
(Assignee)

Comment 4

9 years ago
Created attachment 300447 [details] [diff] [review]
Patch
Assignee: nobody → ventnor.bugzilla
Status: NEW → ASSIGNED
Attachment #300447 - Flags: review?(gavin.sharp)
Comment on attachment 300447 [details] [diff] [review]
Patch

This kinda conflicts with bug 414366 a little bit, but I suppose we could do both, and have the arrow replace the favicon on hover, or something.
Attachment #300447 - Flags: review?(gavin.sharp) → review+

Comment 6

9 years ago
(In reply to comment #5)
> (From update of attachment 300447 [details] [diff] [review])
> and have the arrow replace the favicon on hover, or something.

Seems like a good idea.

> and have the arrow replace the favicon on hover, or something.

yeah, I think this is the best way to integrate both patches.  Note that the bullet is the correct choice, IE7 is incorrectly using the check box (implying that you can navigate to more than one page at a time).
Just filed Bug 415018 to add a history item on the bottom of this menu.
Attachment #300446 - Flags: ui-review?(beltzner) → ui-review+
(Assignee)

Updated

9 years ago
Attachment #300447 - Flags: approval1.9?
Do we want to land these bugs (this one and bug 414366) together or separately?
separately

Note that Michael's patch works for Linux only, which I'm going to fix in bug 414366.

Updated

9 years ago
Attachment #300447 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Component: Places → History
QA Contact: places → history
Checking in browser/base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.960; previous revision: 1.959
done
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 beta4

Comment 12

9 years ago
Created attachment 301856 [details]
screenshot

20080207_0142_firefox-3.0b4pre.en-US.win32.zip

no favicon.
(In reply to comment #12)
> 20080207_0142_firefox-3.0b4pre.en-US.win32.zip
> 
> no favicon.

See comment #10.

Updated

9 years ago
Component: History → Bookmarks & History
QA Contact: history → bookmarks
(Reporter)

Comment 14

8 years ago
Verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.5) Gecko/2008120122 Firefox/3.0.5
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.