389478 - Add favicons on back/forward menus

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, enhancement)

Description

[Emil Ivanov]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.5) Gecko/20070713 Firefox/2.0.0.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.5) Gecko/20070713 Firefox/2.0.0.5

I like the new enhancement with favicons on location bar autocomplete results.
Thus on back/forward menus would be nice too.

Reproducible: Always

Comment 1

[Chris Blore]

-> NEW

Comment 2

[Alex Faaborg [:faaborg] (Firefox UX)]

It would be great to get this into the new integrated menu being worked on over in bug 386228 

Comment 3

[Michael Ventnor]

Attachment: Screenshot

My plan is to add the favicons to all options _except_ the currently selected one, because a favicon on that to would make it harder to notice what position you are already on despite the bold effect. The inconsistency between the favicons and the bullet makes it more noticeable at a glance which position you are in, while still providing the usability benefit of favicons.

Comment 4

[Michael Ventnor]

Attachment: Patch

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 300447 [details] [diff] [review]
Patch

This kinda conflicts with bug 414366 a little bit, but I suppose we could do both, and have the arrow replace the favicon on hover, or something.

Comment 6

[u88484]

(In reply to comment #5)
> (From update of attachment 300447 [details] [diff] [review])
> and have the arrow replace the favicon on hover, or something.

Seems like a good idea.

Comment 7

[Alex Faaborg [:faaborg] (Firefox UX)]

> and have the arrow replace the favicon on hover, or something.

yeah, I think this is the best way to integrate both patches.  Note that the bullet is the correct choice, IE7 is incorrectly using the check box (implying that you can navigate to more than one page at a time).

Comment 8

[Alex Faaborg [:faaborg] (Firefox UX)]

Just filed Bug 415018 to add a history item on the bottom of this menu.

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Do we want to land these bugs (this one and bug 414366) together or separately?

Comment 10

[Dão Gottwald [:dao]]

separately

Note that Michael's patch works for Linux only, which I'm going to fix in bug 414366.

Comment 11

[Reed Loden [:reed]]

Checking in browser/base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.960; previous revision: 1.959
done

Comment 12

[pal-moz]

Attachment: screenshot

20080207_0142_firefox-3.0b4pre.en-US.win32.zip

no favicon.

Comment 13

[Reed Loden [:reed]]

(In reply to comment #12)
> 20080207_0142_firefox-3.0b4pre.en-US.win32.zip
> 
> no favicon.

See comment #10.

Comment 14

[Emil Ivanov]

Verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.5) Gecko/2008120122 Firefox/3.0.5