In light of reviewing the prototype event dialog one particular issue is to address all the style nits throughout the code. This affects all files located under m/c/prototypes/wcap.
Created attachment 273778 [details] shell script This script parses a source file and dumps all the relevant locations that need to be addressed. I received this script from philipp in order to automate the task of finding all style nits, thanks again for taking care. He said that I should mention that this script is "just a hack".
The upcoming patch touches these files: sun-calendar-customize-toolbar.js sun-calendar-customize-toolbar.xul sun-calendar-event-dialog-attendees.js sun-calendar-event-dialog-attendees.xml sun-calendar-event-dialog-attendees.xul sun-calendar-event-dialog-freebusy.xml sun-calendar-event-dialog-recurrence-datepicker.css sun-calendar-event-dialog-recurrence-datepicker.xml sun-calendar-event-dialog-recurrence-preview.css sun-calendar-event-dialog-recurrence-preview.xml sun-calendar-event-dialog-recurrence.js sun-calendar-event-dialog-recurrence.xml sun-calendar-event-dialog-recurrence.xul sun-calendar-event-dialog-reminder.js sun-calendar-event-dialog-reminder.xul sun-calendar-event-dialog-timezone.js sun-calendar-event-dialog-timezone.xul sun-calendar-event-dialog.css sun-calendar-event-dialog.js sun-calendar-event-dialog.xul
Created attachment 274276 [details] [diff] [review] patch v1 This patch applies the above mentioned rules to the list of files that comprise the event dialog. Philipp, would you please be so kind to give this patch a high priority in your review queue as this bug essentially blocks any other patch for the event dialog. Furthermore, assuming that you find remaining style nits I might have missed, I would greatly appreciate that you just post a new version of the patch. Thanks in advance for taking care of this massive patch...
Created attachment 274792 [details] [diff] [review] patch v2 I found a bunch of other things and made massive use of regexes :) I hope I didn't break anything on the way, please test before checking in. I'm requesting review to make sure its tested.
Comment on attachment 274792 [details] [diff] [review] patch v2 I didn't find anything else to complain about -> r=mickey.
Attachment #274792 - Flags: review?(michael.buettner) → review+
I would like to note that Philipp was so kind to set up a new wiki page (see ) that summarizes all those rules above and adds a hell of a lot of other valuable stuff. I would like to establish this page as an established source of knowledge so that it serves as a general reference should any debate concerning style nits come up in the future.  http://wiki.mozilla.org/Calendar:Style_Guide
patch checked in on trunk and MOZILLA_1_8_BRANCH -> FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Verified in lightning (build 2007080603) and sunbird (build 20070806) -> task is fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.