All users were logged out of Bugzilla on October 13th, 2018

Provide a way to get from full text bug listing to short bug listing

RESOLVED FIXED in Bugzilla 3.2

Status

()

--
enhancement
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

({ue})

Bugzilla 3.2
Bug Flags:
approval +

Details

(URL)

Attachments

(1 attachment, 5 obsolete attachments)

(Assignee)

Description

11 years ago
I was "given" (by myself, nacht) a url to full text bug listing and decided I wanted to change several bugs at once, but I can't do that.

I can get from buglist to change several bugs at once AND full text bug listing, and I could probably get from change several bugs at once to full text bug listing (too lazy to check, if i can't, someone tell me and I can fix that while I'm here).

But I can't get from where I am (full text bug listing) to change several bugs at once.

Expected results:
query like links at the bottom that offer other views.
(Assignee)

Comment 1

11 years ago
Created attachment 275350 [details] [diff] [review]
simple link
Assignee: query-and-buglist → timeless
Status: NEW → ASSIGNED
Attachment #275350 - Flags: review?(LpSolit)

Comment 2

11 years ago
Comment on attachment 275350 [details] [diff] [review]
simple link

<a href="buglist.cgi?bug_id=[% ids.join(",") FILTER html %]

They are just a bunch of numbers, so maybe FILTER none would be suitable.

Either way, html is wrong, in URLs one should use url_quote.
Attachment #275350 - Flags: review?(LpSolit) → review-

Updated

11 years ago
OS: Windows XP → All
Hardware: PC → All
(Assignee)

Comment 3

11 years ago
Created attachment 275389 [details] [diff] [review]
less filtery
Attachment #275350 - Attachment is obsolete: true
Attachment #275389 - Flags: review?(vladd)

Updated

11 years ago
Attachment #275389 - Flags: review?(vladd) → review+

Updated

11 years ago
Flags: approval?

Updated

11 years ago
Target Milestone: --- → Bugzilla 3.2

Comment 4

11 years ago
Comment on attachment 275389 [details] [diff] [review]
less filtery

>+    [% ids.push(bug.id) %]

bug.id doesn't exist; it's bug.bug_id


>+    >change several</a>

Change several what? Also, displaying this link in all cases doesn't make sense for users without editbugs privs as they will get an error.

Also, this link should be hidden when the page is printed as it's its main reason to exist.

Could at least the writer of the patch or the reviewer test their patches??
Attachment #275389 - Flags: review-

Updated

11 years ago
Flags: approval?

Updated

11 years ago
Attachment #275389 - Flags: review+
(Assignee)

Comment 5

11 years ago
Created attachment 276015 [details] [diff] [review]
more like dependency trees

http://mxr-test.landfill.bugzilla.org/bugzilla/source/template/en/default/bug/dependency-tree.html.tmpl#87 uses change several w/o specifying whats. but if you insist, we can specify.
Attachment #275389 - Attachment is obsolete: true
Attachment #276015 - Flags: review?(vladd)
Nit: "FILTER none" is really meant for places where filtering would hurt otherwise. In places where it's simply not necessary, filterexceptions.pl entries should rather be used.

Comment 7

11 years ago
Comment on attachment 276015 [details] [diff] [review]
more like dependency trees

I should have seen this coming sooner, but...

From a maintenance point of view, this patch is a nightmare. People will start complaining that they lack other options that they see in the "short" listings.

We are practically duplicating the code that is located in template/en/default/list/list.html.tmpl (the # Navigation Bar stuff):

        [% IF bugs.size > 1 && caneditbugs && !dotweak %]
          <a href="buglist.cgi?[% urlquerypart FILTER html %]
            [%- "&order=$qorder" FILTER html IF order %]&amp;tweak=1"
            >Change&nbsp;Several&nbsp;[% terms.Bugs %]&nbsp;at&nbsp;Once</a>
          |
        [% END %]

(we simply use ids.stuff instead of bugs.stuff).

And that navigation bar at the bottom of the bug list has other links as well, like "Time Summary", "iCalendar", "CSV" or "Remember search".

Rather than duplicate that link/code, simply include the navigation link in the full text bug also! (maybe remove unsuitable bits like "Change Columns", but that should be all of it)
Attachment #276015 - Flags: review?(vladd) → review-

Comment 8

11 years ago
Comment on attachment 276015 [details] [diff] [review]
more like dependency trees

Alternatively, if we want the dirty and quick approach, I guess we could provide a button that switches back to the "Short Format" (bug list).

So basically you would use those 2 buttons (the "Long Format" on the bug list, and the "Short Format" here) in order to "switch" between the 2 viewing modes, and you would have the entire navigation bar (including the "Change Several" option) only in the short-view (bug list stuff).

Comment 9

11 years ago
(In reply to comment #6)
> Nit: "FILTER none" is really meant for places where filtering would hurt
> otherwise. In places where it's simply not necessary, filterexceptions.pl
> entries should rather be used.

No, stop using filterexceptions.pl everytime you are too lazy to write FILTER none. Most of our XSS holes come from abusing it.
(Assignee)

Comment 10

11 years ago
Created attachment 276084 [details] [diff] [review]
short format will be fine
Attachment #276015 - Attachment is obsolete: true
Attachment #276084 - Flags: review?(vladd)

Comment 11

11 years ago
Comment on attachment 276084 [details] [diff] [review]
short format will be fine

The API interface for buglist.cgi seems to be wrong in the patch, it doesn't work for me:

https://landfill.bugzilla.org/bugzilla-tip/buglist.cgi?id=1000,1001

gives me a lot of bugs, not only 1000 and 1001.

https://landfill.bugzilla.org/bugzilla-tip/buglist.cgi?quicksearch=1000,1001

seems to do the trick instead.

Otherwise this looks wonderful! The only thing remaining would be to hide the button when the page is printed per LpSolit comments, if that's possible (but it's not a stopper in my book).
Attachment #276084 - Flags: review?(vladd) → review-

Updated

11 years ago
Summary: provide a way to get from full text bug listing to change several bugs at once → provide a way to get from full text bug listing to short bug listing
(Assignee)

Comment 12

11 years ago
Created attachment 276126 [details] [diff] [review]
bah, inconsistent field names

that one always trips me up when i'm hacking urls
Attachment #276084 - Attachment is obsolete: true
Attachment #276126 - Flags: review?(vladd)
(Assignee)

Comment 13

11 years ago
Created attachment 276127 [details] [diff] [review]
bug, really
Attachment #276126 - Attachment is obsolete: true
Attachment #276127 - Flags: review?(vladd)
Attachment #276126 - Flags: review?(vladd)

Updated

11 years ago
Attachment #276127 - Flags: review?(vladd) → review+

Updated

11 years ago
Flags: approval?

Updated

11 years ago
Summary: provide a way to get from full text bug listing to short bug listing → Provide a way to get from full text bug listing to short bug listing

Updated

11 years ago
Flags: approval? → approval+
(Assignee)

Comment 14

11 years ago
Comment on attachment 276127 [details] [diff] [review]
bug, really

mozilla/webtools/bugzilla/template/en/default/bug/show-multiple.html.tmpl 	1.38
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED

Updated

11 years ago
Blocks: 395896
You need to log in before you can comment on or make changes to this bug.