389611 - Don't treat filetypes as protocol handlers on windows

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Daniel Veditz [:dveditz]]

On Windows when we encounter an unknown protocol handler we look in the windows registry to see if it exists. However we just look for the existence of HKR/scheme and do not check to see if it has a "URL Protocol" value. Therefore we'll think any registered filetype is a protocol so we think we can load things like "giffile:blah" etc. and call ShellExecute() on them.

So far this appears harmless (at least on WinXP) because ShellExecute() won't load them, but I have not done extensive testing and haven't looked at anything but WinXP so far.

Comment 1

[Daniel Veditz [:dveditz]]

This is the issue mentioned in the first part of http://larholm.com/2007/07/25/mozilla-protocol-abuse/

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

a patch will require bug 389632's patch, because without it we show the dialog for any protocol no matter whether it exists

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 274078 [details] [diff] [review]
patch

Looks good.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 274078 [details] [diff] [review]
patch

do we want this on 1.8.0.13 too?

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in win/nsOSHelperAppService.cpp;
/cvsroot/mozilla/uriloader/exthandler/win/nsOSHelperAppService.cpp,v  <--  nsOSHelperAppService.cpp
new revision: 1.73; previous revision: 1.72
done

Comment 7

[Daniel Veditz [:dveditz]]

Comment on attachment 274078 [details] [diff] [review]
patch

approved for 1.8.1.7 and 1.8.0.14, a=dveditz for release-drivers

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

MOZILLA_1_8_BRANCH:
Checking in nsOSHelperAppService.cpp;
/cvsroot/mozilla/uriloader/exthandler/win/nsOSHelperAppService.cpp,v  <--  nsOSHelperAppService.cpp
new revision: 1.63.4.3; previous revision: 1.63.4.2
done

MOZILLA_1_8_0_BRANCH:
Checking in nsOSHelperAppService.cpp;
/cvsroot/mozilla/uriloader/exthandler/win/nsOSHelperAppService.cpp,v  <--  nsOSHelperAppService.cpp
new revision: 1.63.4.1.4.1; previous revision: 1.63.4.1
done