Closed
Bug 389636
Opened 17 years ago
Closed 17 years ago
[FIX]"ASSERTION: aDocument must be current doc of aParent" and more with cloned <xul:richlistbox>
Categories
(Core :: XBL, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla1.9beta1
People
(Reporter: jruderman, Assigned: bzbarsky)
References
Details
(Keywords: assertion, testcase)
Attachments
(2 files)
|
526 bytes,
text/html
|
Details | |
|
1.27 KB,
patch
|
sicking
:
review+
sicking
:
superreview+
sicking
:
approval1.9+
|
Details | Diff | Splinter Review |
Loading the testcase triggers two assertions I haven't seen before: ###!!! ASSERTION: aDocument must be current doc of aParent: '!aParent || aDocument == aParent->GetCurrentDoc()', file mozilla/content/base/src/nsGenericElement.cpp, line 1931 ###!!! ASSERTION: Parent in document but flagged as forcing XBL: '!aParent || !aDocument || !aParent->HasFlag(NODE_FORCE_XBL_BINDINGS)', file mozilla/content/base/src/nsGenericElement.cpp, line 1944 It also triggers some assertions I have seen elsewhere: ###!!! ASSERTION: element not in the document: 'doc', file mozilla/layout/base/nsChildIterator.cpp, line 62 (bug 335896?) ###!!! ASSERTION: Shallow unbind won't clear document and binding parent on kids!: 'aDeep || (!GetCurrentDoc() && !GetBindingParent())', file mozilla/content/base/src/nsGenericElement.cpp, line 2082 (bug 360078 comment 8?)
|
Assignee | |
Comment 1•17 years ago
|
||
We're constructing frames for a <xul:richlistbox>. One of the kids for it according to the content iterator is a <xul:scrollbox> which has a null GetCurrentDoc(). The asserts follow. Why does something with a non-null GetCurrentDoc() (the <xul:richlistbox>) have a kid with a null GetCurrentDoc()?
|
|
Assignee | |
Comment 2•17 years ago
|
||
Oh, this is fun. The richlistbox has anon content and the NODE_FORCE_XBL_BINDINGS flag. The first time we append it, we're not appending into a document, so nothing happens. Then we remove from the <div> when appending to the <body>, don't tear down the XBL binding (because |document| is null) and unset the flag. Then we reinsert, don't bind the anonymous content, and end up in this state.
|
|
Assignee | |
Comment 3•17 years ago
|
||
It's a little hacky... but I think it's acceptable.
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #274033 -
Flags: superreview?(jonas)
Attachment #274033 -
Flags: review?(jonas)
|
|
Assignee | |
Updated•17 years ago
|
Priority: -- → P2
Summary: "ASSERTION: aDocument must be current doc of aParent" and more with cloned <xul:richlistbox> → [FIX]"ASSERTION: aDocument must be current doc of aParent" and more with cloned <xul:richlistbox>
Target Milestone: --- → mozilla1.9beta2
Attachment #274033 -
Flags: superreview?(jonas)
Attachment #274033 -
Flags: superreview+
Attachment #274033 -
Flags: review?(jonas)
Attachment #274033 -
Flags: review+
Attachment #274033 -
Flags: approval1.9+
|
|
Assignee | |
Comment 4•17 years ago
|
||
Checked in, including the test as a "reftest". I wonder whether we could set up a mochitest here, though (e.g. still able to get the anon kids when they should be gone, or something).
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•