389641 - RDFItemUpdater shouldn't check for updates for items with pending optypes

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Dave Townsend [:mossop]]

Comment 1

[Dave Townsend [:mossop]]

Attachment: patch rev 1

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 273941 [details] [diff] [review]
patch rev 1

Seeking approval for this simple patch which stops us attempting to find updates for add-ons that already have new versions waiting to be installed.

Comment 3

[Robert Strong (they/them - no direct email)]

(In reply to comment #2)
> (From update of attachment 273941 [details] [diff] [review])
> Seeking approval for this simple patch which stops us attempting to find
> updates for add-ons that already have new versions waiting to be installed.
I thought that case was already handled previously. Just for my own clarity, doesn't this just change it so we don't check for updates in the background for extensions that have a pending disable / enable operation?

Drivers, this is a low risk patch to make the background update check behave the same as the ui's update check.

Comment 4

[Dave Townsend [:mossop]]

(In reply to comment #3)
> I thought that case was already handled previously. Just for my own clarity,
> doesn't this just change it so we don't check for updates in the background for
> extensions that have a pending disable / enable operation?

You're right I didn't read close enough, it changes the restriction to stop check for add-ons with any pending operation.

Comment 5

[Robert Strong (they/them - no direct email)]

Dave, as a side note... it is my understanding that for M8 driver approval is required for gecko 1.9 changes and is not required for toolkit or browser. I've asked for verification that this is truly the case.

Comment 6

[Robert Strong (they/them - no direct email)]

Comment on attachment 273941 [details] [diff] [review]
patch rev 1

Per http://groups.google.com/group/mozilla.dev.planning/browse_thread/thread/3e988240291a846b/02cda78d0c0b7707#02cda78d0c0b7707

On the browser/toolkit the tree is still considered open, as the feature
freeze for the front end is targeted at M8.

Clearing a and go ahead and check this in. Thanks!

Comment 7

[Dave Townsend [:mossop]]

Checking in toolkit/mozapps/extensions/src/nsExtensionManager.js.in;
/cvsroot/mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in,v  <--  nsExtensionManager.js.in
new revision: 1.232; previous revision: 1.231
done