Closed Bug 389693 Opened 17 years ago Closed 17 years ago

[Proto] Event dialog: File->New->Event fails (Error: args.onNewEvent is not a function)

Categories

(Calendar :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: ssitter, Assigned: mschroeder)

Details

Attachments

(1 file)

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.6pre) Gecko/20070726 Calendar/0.7pre

Steps To Reproduce:
1. Open the New Event dialog e.g. by using the toolbar button
2. In the dialog select menu File -> New -> Event

Actual Results:
Nothing happens. Error Console shows:

  Error: args.onNewEvent is not a function
  Source File: chrome://calendar/content/sun-calendar-event-dialog.js
  Line: 1578

Expected Results:
No error. Another New Event dialog is shown.
Attached patch Patch v1 — — Splinter Review
Patch from bug 386589 removed changes made between creation and check in of the patch.
Assignee: nobody → mschroeder
Status: NEW → ASSIGNED
Attachment #274160 - Flags: review?(michael.buettner)
Comment on attachment 274160 [details] [diff] [review]
Patch v1

>+    // this will be called if file->new has been selected from within the dialog
>+    args.onNewEvent = function(calendar) {
>+        createEventWithDialog(calendar, null, null);
>+    }
I'd just omit the second and third argument and write createEventWithDialog(calendar) in order to stay consistent with other occurrences of this call (e.g. messenger-overlay-???.xul). But both versions are just fine, as they essentially do the same. Thanks for the patch Martin. r=mickey.
Attachment #274160 - Flags: review?(michael.buettner) → review+
OS: Windows 2000 → All
Hardware: PC → All
Target Milestone: --- → 0.7
Keywords: checkin-needed
patch checked in on trunk and MOZILLA_1_8_BRANCH

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Verified in Lightning build 2007073103 (Linux) and Sunbird build 20070731 (Windows) -> task is fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: